Skip to content

Conversation

@kxzazz
Copy link

@kxzazz kxzazz commented Apr 8, 2024

Add the option to select the audio output device in the dialog.

Changelog

Closes #19

Added AudioOutputSelector in the SettingsDialog


Screenshots

Before:

image

After:

image

@renandincer
Copy link
Member

thank you for the PR @kxzazz!

@third774 third774 self-requested a review April 9, 2024 16:11
@third774
Copy link
Collaborator

third774 commented Apr 9, 2024

Thanks for the contribution, @kxzazz! I think we've got some other non-trivial work to do in order to make this work reliably (for instance, when an audio output device is disconnected), so I'm going to hold off on merging this PR for now. Once we've got the other pieces in place, we can use this to add the UI though!

@kxzazz
Copy link
Author

kxzazz commented Apr 9, 2024

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output source selection

4 participants