-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(extra-natives-rdr3): Add interior natives #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(extra-natives-rdr3): Add interior natives #3679
Conversation
7857c11 to
07405f8
Compare
|
I have added |
07405f8 to
e1fcaa1
Compare
|
dolu_tool.zip |
| --- | ||
|
|
||
| ## GET_INTERIOR_ROOM_REFLECTION_PROBE_GUID | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This misses a C-style definition of the native.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be OK ? i didn't see any usage of uint64_t return type in other natives
uint64_t GET_INTERIOR_ROOM_REFLECTION_PROBE_GUID(int interiorId, int roomId, int probeId);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdint definitions are sadly not supported, you can probably use unsigned long long if you really need a range of an unsigned 64-bit int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok it's updated, yes the guid is useful to get reflection prob hash for mlo debug purpose
Thx for your review :)
edb1e6c to
0b5f01d
Compare
|
Native definitions look good now. Please fix the compile errors for V, will review then. |
0b5f01d to
bcdeeec
Compare
radium-cfx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks for your contribution!

Goal of this PR
Port interior-related natives from FiveM to RDR3, enabling interior debugging and manipulation capabilities in RedM. This includes adding comprehensive interior archetype debugging, room/portal management, and reflection probe support specifically for RDR3.
How is this PR achieving the goal
Unified Codebase:
InteriorExtraNatives.cppfrom FiveM into RDR3 component viacomponent.luato eliminate code duplication#ifdef GTA_FIVE/#elif IS_RDR3) to handle platform-specific differencesDECLARE_ACCESSORmacro for consistent API across platformsRDR3-Specific Structures:
InteriorProxy::Impl1491struct with correct memory offsets for RDR3CReflectionProbestruct based on game file data analysisCMloRoomDefto includereflectionProbesfield for RDR3Enhanced Debugging:
INTERIOR_DEBUGnative with archetype info, position/rotation, entities extentsPorted Natives from FiveM:
Core Interior Natives:
GET_INTERIOR_ROTATIONGET_INTERIOR_ENTITIES_EXTENTSRoom Natives:
GET_INTERIOR_ROOM_COUNTGET_INTERIOR_ROOM_INDEX_BY_HASHGET_INTERIOR_ROOM_NAMEGET_INTERIOR_ROOM_FLAGSET_INTERIOR_ROOM_FLAGGET_INTERIOR_ROOM_EXTENTSSET_INTERIOR_ROOM_EXTENTSGET_INTERIOR_ROOM_TIMECYCLESET_INTERIOR_ROOM_TIMECYCLEPortal Natives:
GET_INTERIOR_PORTAL_COUNTGET_INTERIOR_PORTAL_CORNER_POSITIONSET_INTERIOR_PORTAL_CORNER_POSITIONGET_INTERIOR_PORTAL_ROOM_FROMSET_INTERIOR_PORTAL_ROOM_FROMGET_INTERIOR_PORTAL_ROOM_TOSET_INTERIOR_PORTAL_ROOM_TOGET_INTERIOR_PORTAL_FLAGSET_INTERIOR_PORTAL_FLAGGET_INTERIOR_PORTAL_ENTITY_COUNTGET_INTERIOR_PORTAL_ENTITY_ARCHETYPEGET_INTERIOR_PORTAL_ENTITY_FLAGSET_INTERIOR_PORTAL_ENTITY_FLAGGET_INTERIOR_PORTAL_ENTITY_POSITIONGET_INTERIOR_PORTAL_ENTITY_ROTATIONNew RDR3-Specific Natives:
Reflection Probe Getters:
GET_INTERIOR_ROOM_REFLECTION_PROBE_COUNTGET_INTERIOR_ROOM_REFLECTION_PROBE_EXTENTSGET_INTERIOR_ROOM_REFLECTION_PROBE_CENTER_OFFSETGET_INTERIOR_ROOM_REFLECTION_PROBE_INFLUENCE_EXTENTSGET_INTERIOR_ROOM_REFLECTION_PROBE_ROTATIONGET_INTERIOR_ROOM_REFLECTION_PROBE_PRIORITYGET_INTERIOR_ROOM_REFLECTION_PROBE_GUIDReflection Probe Setters:
SET_INTERIOR_ROOM_REFLECTION_PROBE_EXTENTSSET_INTERIOR_ROOM_REFLECTION_PROBE_CENTER_OFFSETSET_INTERIOR_ROOM_REFLECTION_PROBE_INFLUENCE_EXTENTSSET_INTERIOR_ROOM_REFLECTION_PROBE_ROTATIONSET_INTERIOR_ROOM_REFLECTION_PROBE_PRIORITYThis PR applies to the following area(s)
Successfully tested on
Game builds: RDR3 Build 1491
Platforms: Windows
Checklist
Fixes issues
N/A - New feature implementation
Example of usage with dolu_tool
