-
Notifications
You must be signed in to change notification settings - Fork 2k
[ENH]: Skip caching for output collections in frontend #5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Skip caching for output collections in frontend #5956
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Skip caching output collections and streamline tests Introduces metadata-based detection of output collections so the frontend cache avoids storing their Key Changes• Added Affected Areas• This summary was automatically generated by @propel-code-bot |
f782230 to
3acb2ad
Compare
29770d5 to
7c549e0
Compare
- Add is_output_collection() helper method to Collection - Skip caching for output collections in set_collection_with_segments - Add test for is_output_collection()
3acb2ad to
dbbe74c
Compare
7c549e0 to
a689a30
Compare
| chromadb/proto/logservice.proto | ||
| chromadb/proto/logservice.proto \ | ||
| chromadb/proto/heapservice.proto | ||
| @mv ../go/pkg/proto/coordinatorpb/chromadb/proto/logservice*.go ../go/pkg/proto/logservicepb/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Maintainability] For consistency with how logservice.proto's generated files are handled, it seems heapservice.proto should also have its generated files moved to a dedicated directory (e.g., ../go/pkg/proto/heapservicepb/).
Currently, the generated heapservice*.go files will be moved to the generic coordinatorpb directory by the wildcard mv command on the next line. Adding a specific move command for heapservice would align with the pattern set by logservice.
| @mv ../go/pkg/proto/coordinatorpb/chromadb/proto/logservice*.go ../go/pkg/proto/logservicepb/ | |
| @mv ../go/pkg/proto/coordinatorpb/chromadb/proto/logservice*.go ../go/pkg/proto/logservicepb/ | |
| @mv ../go/pkg/proto/coordinatorpb/chromadb/proto/heapservice*.go ../go/pkg/proto/heapservicepb/ |
Context for Agents
For consistency with how `logservice.proto`'s generated files are handled, it seems `heapservice.proto` should also have its generated files moved to a dedicated directory (e.g., `../go/pkg/proto/heapservicepb/`).
Currently, the generated `heapservice*.go` files will be moved to the generic `coordinatorpb` directory by the wildcard `mv` command on the next line. Adding a specific move command for `heapservice` would align with the pattern set by `logservice`.
```suggestion
@mv ../go/pkg/proto/coordinatorpb/chromadb/proto/logservice*.go ../go/pkg/proto/logservicepb/
@mv ../go/pkg/proto/coordinatorpb/chromadb/proto/heapservice*.go ../go/pkg/proto/heapservicepb/
```
File: idl/makefile
Line: 31|
I am a little bit on the fence about this conditional caching. The intent of the cache is to remove the sysdb from hot path situations. |

Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?