[CHORE] Fix JS CI (#5393)

## Description of changes

Wire new JS clients to CI. The integration script takes advantage of the
new API generator and testing suite that are able to start a server on
their own from the Rust code.

## Test plan
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

Author: itaismith

.github/workflows/_javascript-client-tests.yml

@@ -17,6 +17,6 @@ jobs:
         with:
           version: "9"
       - name: Install dependencies
-        run: cd clients/js && pnpm install --no-frozen-lockfile
+        run: cd clients/new-js && pnpm install --no-frozen-lockfile
       - name: Test
         run: bin/ts-integration-test.sh

bin/ts-integration-test.sh

@@ -1,60 +1,24 @@
 #!/usr/bin/env bash
 set -e
-# Function to check if server is ready
-check_server() {
-    curl -s http://localhost:8000/openapi.json > /dev/null
-    return $?
-}
-# Function to wait for server with exponential backoff
-wait_for_server() {
-    local max_attempts=10
-    local attempt=1
-    local base_delay=1
-    local max_delay=32
-    echo "Waiting for server to start..."
-    while [ $attempt -le $max_attempts ]; do
-        if check_server; then
-            echo "Server is ready!"
-            return 0
-        fi
-        delay=$((base_delay * (2 ** (attempt - 1))))  # Exponential backoff
-        delay=$((delay < max_delay ? delay : max_delay))  # Cap at max_delay
-        echo "Attempt $attempt/$max_attempts: Server not ready, waiting ${delay}s..."
-        sleep $delay
-        attempt=$((attempt + 1))
-    done
-    echo "Error: Server failed to start after $max_attempts attempts"
-    return 1
-}
-# Start the Chroma server in the background
-echo "Building and starting Chroma server..."
-cargo build --bin chroma
-cargo run --bin chroma run &
-SERVER_PID=$!
-# Wait for the server to be ready
-wait_for_server
 
 # Install dependencies
-cd clients/js
+cd clients/new-js
+pnpm build
 
 # Generate the JS client
 echo "Generating JS client..."
-pnpm genapi
+pnpm genapi:chromadb
 
-# Cleanup: kill the server process
-kill $SERVER_PID
-
-pnpm prettier
-
-# run git diff and check if packages/chromadb-core/src/generated/ has changed
+# run git diff and check if packages/chromadb/src/api/ has changed
 echo "Checking for changes in generated client..."
-if ! git diff --quiet --exit-code packages/chromadb-core/src/generated/; then
+if ! git diff --quiet --exit-code packages/chromadb/src/api/; then
     echo "Error: Generated JS client has changed. Please commit the changes."
-    git diff packages/chromadb-core/src/generated/ | cat
+    git diff packages/chromadb/src/api/ | cat
     exit 1
 fi
 echo "No changes detected in generated client."
 
 # Install dependencies and run tests
 echo "Running tests..."
-pnpm -r test --verbose
+cd packages/chromadb
+pnpm test --verbose

clients/new-js/packages/chromadb/src/api/client.gen.ts

@@ -16,4 +16,4 @@ export type CreateClientConfig<T extends DefaultClientOptions = ClientOptions> =
 export const client = createClient(createConfig<ClientOptions>({
     baseUrl: 'http://localhost:8000',
     throwOnError: true
-}));
+}));

clients/new-js/packages/chromadb/src/api/index.ts

@@ -1,3 +1,3 @@
 // This file is auto-generated by @hey-api/openapi-ts
 export * from './types.gen';
-export * from './sdk.gen';
+export * from './sdk.gen';

clients/new-js/packages/chromadb/src/api/sdk.gen.ts

@@ -28,7 +28,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Retrieves a collection by Chroma Resource Name.
      */
@@ -38,7 +38,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Health check endpoint that returns 200 if the server and executor are ready
      */
@@ -48,7 +48,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Heartbeat endpoint that returns a nanosecond timestamp of the current time.
      */
@@ -58,7 +58,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Pre-flight checks endpoint reporting basic readiness info.
      */
@@ -68,7 +68,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Reset endpoint allowing authorized users to reset the database.
      */
@@ -78,7 +78,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Creates a new tenant.
      */
@@ -92,7 +92,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Returns an existing tenant by name.
      */
@@ -102,7 +102,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Updates an existing tenant by name.
      */
@@ -116,7 +116,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Lists all databases for a given tenant.
      */
@@ -126,7 +126,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Creates a new database for a given tenant.
      */
@@ -140,7 +140,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Deletes a specific database.
      */
@@ -150,7 +150,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Retrieves a specific database by name.
      */
@@ -160,7 +160,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Lists all collections in the specified database.
      */
@@ -170,7 +170,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Creates a new collection under the specified database.
      */
@@ -184,7 +184,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Deletes a collection in a given database.
      */
@@ -194,7 +194,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Retrieves a collection by ID or name.
      */
@@ -204,7 +204,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Updates an existing collection's name or metadata.
      */
@@ -218,7 +218,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Adds records to a collection.
      */
@@ -232,7 +232,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Retrieves the number of records in a collection.
      */
@@ -242,7 +242,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Deletes records in a collection. Can filter by IDs or metadata.
      */
@@ -256,7 +256,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Forks an existing collection.
      */
@@ -270,7 +270,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Retrieves records from a collection by ID or metadata filter.
      */
@@ -284,7 +284,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Query a collection in a variety of ways, including vector search, metadata filtering, and full-text search
      */
@@ -298,7 +298,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Updates records in a collection by ID.
      */
@@ -312,7 +312,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Upserts records in a collection (create if not exists, otherwise update).
      */
@@ -326,7 +326,7 @@ export class DefaultService {
             }
         });
     }
-
+    
     /**
      * Retrieves the total number of collections in a given database.
      */
@@ -336,7 +336,7 @@ export class DefaultService {
             ...options
         });
     }
-
+    
     /**
      * Returns the version of the server.
      */
@@ -346,5 +346,5 @@ export class DefaultService {
             ...options
         });
     }
-
-}
+    
+}

clients/new-js/packages/chromadb/src/api/types.gen.ts

@@ -1320,4 +1320,4 @@ export type VersionResponse = VersionResponses[keyof VersionResponses];
 
 export type ClientOptions = {
     baseUrl: 'http://127.0.0.1:8000' | (string & {});
-};
+};