Rename ReadyOrNotReady

Author: rescrv

go/pkg/sysdb/coordinator/task.go

@@ -92,7 +92,7 @@ func (s *Coordinator) AttachFunction(ctx context.Context, req *coordinatorpb.Att
 	err := s.catalog.txImpl.Transaction(ctx, func(txCtx context.Context) error {
 		// Check if there's any active (ready, non-deleted) attached function for this collection
 		// We only allow one active attached function per collection
-		existingAttachedFunctions, err := s.catalog.metaDomain.AttachedFunctionDb(txCtx).GetAnyByCollectionID(req.InputCollectionId)
+		existingAttachedFunctions, err := s.catalog.metaDomain.AttachedFunctionDb(txCtx).GetReadyOrNonReadyByCollectionID(req.InputCollectionId)
 		if err != nil {
 			log.Error("AttachFunction: failed to check for existing attached function", zap.Error(err))
 			return err

go/pkg/sysdb/metastore/db/dbmodel/mocks/IAttachedFunctionDb.go

@@ -42,7 +42,7 @@ type IAttachedFunctionDb interface {
 	GetByID(id uuid.UUID) (*AttachedFunction, error)
 	GetAnyByID(id uuid.UUID) (*AttachedFunction, error) // TODO(tanujnay112): Consolidate all the getters.
 	GetByCollectionID(inputCollectionID string) ([]*AttachedFunction, error)
-	GetAnyByCollectionID(inputCollectionID string) ([]*AttachedFunction, error)
+	GetReadyOrNonReadyByCollectionID(inputCollectionID string) ([]*AttachedFunction, error)
 	Update(attachedFunction *AttachedFunction) error
 	Finish(id uuid.UUID) error
 	SoftDelete(inputCollectionID string, name string) error