choria on puppet 8

[dom0317]

Does choria support / work with puppet 8?
Or is there anyone using it with puppet 8?

We are looking at replacing mcollective with choria and upgrading from puppet 3.8 to puppet 7 or 8. This will be on RHEL 8. We would like to go to puppet 8. On preliminary investigations choria is working with with puppet 7 but hitting an issue with puppet 8.

[ripienaar]

It should now work, I didnt announce the release yet on the blog as I want to give ample period for feedback but I think at this point if you follow the normal guide it will just work on puppet 8.

[dom0317]

Thanks, that is good news.

In limited testing I found it does work ok. I can successfully run some of our existing mcollective actions.
I did find 3 small issues:

1. In choria-mcorpc-support-2.26.2/lib/mcollective/shell.rb
   at the end of runcommand method changed:
   @status.thread.killd
   to
   @status.thread.kill if respond_to?("@status.thread")
   Otherwise got a "undefined method `thread' " error on mco rpc actions and mco plugin package.

2. In choria-mcollective_agent_puppet-2.4.2/files/mcollective/agent/puppet.rb
   in run method changed:
   env = ENV.clone
   to
   env = ENV.to_h

3. choria-mcorpc-support-2.26.2/lib/mcollective/pluginpackager/forge_packager.rb
   This only gave a warning message, but changed:
   erb = ERB.new(File.read(infile), 0, "-")
   to
   erb = ERB.new(File.read(infile), trim_mode: "-")

[ripienaar]

Issues and PRs for these would be great

[smortex]

Hey! I updated one $WORK site today to Puppet 8.

Two choria-related issues when using the latest modules from the forge prevent choria to work:

1. (#26) Add gem dependency for Puppet 8 support choria-plugins/mcollective_choria#27
2. (#60) Fix Ruby 3.2 compat issue with ENV.clone choria-plugins/puppet-agent#61

After adjusting the files by hand, everything seems to be fine.

I did not hurt these issues on my home infra because:

1. there I run FreeBSD and is this case the module ensure the package of the ruby gem is installed rather than installing the gem directly;
2. FreeBSD currently default to Ruby 3.1 which has not the ENV.clone deprecation.

New releases of these plugins should make Puppet 8 support complete.

[smortex]

In complement, some modules still use the removed File#exists?, link to PR that fix them:

• (misc) Fix usage of legacy File.exists? puppet-mcollective#330
• Switch CI to GitHub Actions choria-plugins/package-agent#27 (fixed while petting CI)
• (misc) Fix usage of legacy File#exists? choria-plugins/filemgr-agent#5

These also would require a new release to fix Puppet 8 support.

[ripienaar]

Thanks @smortex I've merged all these, will look to do releases this week as I think we're getting quite close now

[smortex]

Cool!

We also need a release of choria-mcorpc-support that include:

• (#186) remove thread.kill choria-mcorpc-support#187