Add support for generating BitVM cache via CLI command and minor refactor #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `GenerateBitvmCache` actor in the CLI. - Added `parse_cli_args` function to handle CLI arguments without loading configuration. - Implemented early command handling for `generate-bitvm-cache` in the main function, allowing for cache generation without requiring full configuration. - Enhanced error handling for CLI argument parsing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CLI support for generating the BitVM cache independently without requiring full configuration. The implementation introduces a new GenerateBitvmCache actor and handles it early in the main function before configuration loading.
Key changes:
- Introduced
GenerateBitvmCacheactor for cache generation without config requirements - Added
parse_cli_argsfunction to parse CLI arguments independently of configuration loading - Implemented early command handling that bypasses configuration requirements for cache generation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/cli.rs | Adds GenerateBitvmCache actor enum variant and parse_cli_args function for config-independent argument parsing |
| core/src/main.rs | Implements early handling of GenerateBitvmCache command before config loading, and adds unreachable branch for the actor in the main match statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ekrembal
previously approved these changes
Dec 1, 2025
mmtftr
changed the title
atacann
reviewed
Dec 4, 2025
Contributor
atacann
left a comment
atacann
left a comment
There was a problem hiding this comment.
LGTM, its just that cli::Actors::GenerateBitvmCache looks funny :D, we could use clap Subcommand maybe
mmtftr
commented
Dec 4, 2025
atacann
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GenerateBitvmCacheactor in the CLI.parse_cli_argsfunction to handle CLI arguments without loading configuration.generate-bitvm-cachein the main function, allowing for cache generation without requiring full configuration.Describe what this pull request does, here.
Linked Issues