Unsafe unretained can cause a crash

[ramakula]

Hello @ccgus,
Is there any specific reason why you have used __unsafe_unretained instead of weak in FMDatabasePool.h? __unsafe_unretained can lead to dangling pointer. Here is what I think: "If you try to access an unowned reference after the instance that it references is deallocated, you will trigger a runtime error. Use unowned references only when you are sure that the reference will always refer to an instance.".

[ccgus]

Probably because I wrote these bits before weak was introduced.

[ramakula]

Ah makes sense. I can go ahead and submit a pull request. Let me know.

[ccgus]

I've got it tagged for 3.0 so if you want to make the change, you can do it there. I'm not going to make a behavior change like that in the 2.x cycle (even though it's probably safe to do. It's the probably part that worries me)

[ramakula]

Got it