fix(deploy): include the index config in the changes

Author: JesusTheHun

packages/deploy/src/clusterChanges/applyCouchbaseClusterChanges.ts

@@ -637,13 +637,15 @@ async function applyUpsertSearchIndex(
     scopeName: change.scope,
   });
 
-  if (change.type === 'updateSearchIndex') {
-    const searchIndex = await cluster
-      .bucket(change.bucket)
-      .scope(change.scope)
-      .searchIndexes()
-      .getIndex(change.name);
+  const searchIndexes = await cluster
+    .bucket(change.bucket)
+    .scope(change.scope)
+    .searchIndexes()
+    .getAllIndexes();
+
+  const searchIndex = searchIndexes.find((s) => s.name === change.name);
 
+  if (searchIndex) {
     config.uuid = searchIndex.uuid;
     config.sourceUUID = searchIndex.sourceUuid;
   }

packages/deploy/src/clusterChanges/getCouchbaseClusterChanges.spec.ts

@@ -579,6 +579,11 @@ describe('getCouchbaseClusterChanges', () => {
         bucket: 'bucket1',
         scope: 'scope1',
         configFn: searchIndexConfigFn1,
+        config: searchIndexConfigFn1({
+          sourceName: 'bucket1',
+          bucketName: 'bucket1',
+          scopeName: 'scope1',
+        }),
       },
     ]);
   });
@@ -628,6 +633,11 @@ describe('getCouchbaseClusterChanges', () => {
         bucket: 'bucket1',
         scope: 'scope1',
         configFn: searchIndexConfigFn2,
+        config: searchIndexConfigFn2({
+          sourceName: 'bucket1',
+          bucketName: 'bucket1',
+          scopeName: 'scope1',
+        }),
       },
     ]);
   });

packages/deploy/src/clusterChanges/getCouchbaseClusterChanges.ts

@@ -720,6 +720,11 @@ function getNewSearchIndexes(
         bucket: bucketName,
         scope: scopeName,
         configFn: requestedIndexFn,
+        config: requestedIndexFn({
+          sourceName: bucketName,
+          bucketName,
+          scopeName,
+        }),
       };
     });
 }
@@ -762,16 +767,17 @@ function getUpdatedSearchIndexes(
       invariant(currentIndexFn, 'Current index definition not found.');
       invariant(requestedIndexFn, 'Requested index definition not found.');
 
-      const indexHaveChanged =
+      const indexHasChanged =
         JSON.stringify(currentIndexConfig) !== JSON.stringify(requestedIndexConfig);
 
-      if (indexHaveChanged) {
+      if (indexHasChanged) {
         return {
           type: 'updateSearchIndex',
           name: b,
           bucket: bucketName,
           scope: scopeName,
           configFn: requestedIndexFn,
+          config: requestedIndexConfig,
         } satisfies CouchbaseClusterChangeUpdateSearchIndex;
       }
     })

packages/deploy/src/clusterChanges/types.ts

@@ -164,6 +164,7 @@ export type CouchbaseClusterChangeCreateSearchIndex = {
    */
   name: string;
   configFn: CouchbaseClusterSearchIndexConfig;
+  config: ReturnType<CouchbaseClusterSearchIndexConfig>;
 };
 
 export type CouchbaseClusterChangeUpdateSearchIndex = {
@@ -175,6 +176,7 @@ export type CouchbaseClusterChangeUpdateSearchIndex = {
    */
   name: string;
   configFn: CouchbaseClusterSearchIndexConfig;
+  config: ReturnType<CouchbaseClusterSearchIndexConfig>;
 };
 
 export type CouchbaseClusterChangeDropSearchIndex = {