test(deploy): relentlessly retry getSearchIndexes

Author: JesusTheHun

.github/workflows/tests.yml

@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - main
+      - narrow-deploy-500
   issue_comment:
     types: [created]
 
@@ -22,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        couchbase-server-version: [ 'enterprise-7.6.1', 'enterprise-7.6.2', 'enterprise-7.6.3', 'enterprise-7.6.4' ]
+        couchbase-server-version: [ 'enterprise-7.6.4' ]
     services:
       couchbase:
         image: couchbase:${{ matrix.couchbase-server-version }}
@@ -111,7 +112,7 @@ jobs:
 
       - name: Upload Couchbase Logs
         if: failure() && steps.cb-logs.conclusion == 'success'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: couchbase-logs-${{ github.sha }}-${{ github.run_id }}
           path: couchbase-logs-${{ github.sha }}-${{ github.run_id }}.tar.gz

packages/deploy/src/clusterChanges/applyCouchbaseClusterChanges.ts

@@ -645,18 +645,27 @@ async function applyUpsertSearchIndex(
     scopeName: change.scope,
   });
 
-  const searchIndexes = await cluster
-    .bucket(change.bucket)
-    .scope(change.scope)
-    .searchIndexes()
-    .getAllIndexes({ timeout: 15_000 });
-
-  const searchIndex = searchIndexes.find((s) => s.name === change.name);
-
-  if (searchIndex) {
-    config.uuid = searchIndex.uuid;
-    config.sourceUUID = searchIndex.sourceUuid;
-  }
+  await retry(
+    async () => {
+      const searchIndexes = await cluster
+        .bucket(change.bucket)
+        .scope(change.scope)
+        .searchIndexes()
+        .getAllIndexes();
+
+      const searchIndex = searchIndexes.find((s) => s.name === change.name);
+
+      if (searchIndex) {
+        config.uuid = searchIndex.uuid;
+        config.sourceUUID = searchIndex.sourceUuid;
+      }
+    },
+    {
+      delay: 1_000,
+      retries: 'INFINITELY',
+      timeout: opts.timeout,
+    }
+  );
 
   console.log(
     `${getTimePrefix()} Requesting creation of search index "${change.bucket} # ${change.name}"`

tests/deploy/tests/applyCouchbaseClusterChanges.spec.ts

@@ -128,7 +128,7 @@ describe.runIf(
     );
 
     await applyCouchbaseClusterChanges(cluster, getApiConfig(false), changes, {
-      timeout: 45_000,
+      timeout: 180_000,
     });
 
     // Check keyspaces //