Skip to content

Conversation

@Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 3, 2025

Description

This PR handles the requirement that users must verify their seed phrase after performing five critical actions or after two weeks since the wallet was initialized.

The recording of critical actions and the checking of the time limit are already handled by the core. Currently, we need to catch the Agent.SEED_PHRASE_NOT_VERIFIED error or check the result of the function Agent.agent.isVerificationEnforced.

Here, after the user performs 5 critical actions, the remaining time is reduced to 1 day, and once this time is reached, a modal will appear requiring the user to verify their seed phrase.

To test this function, you can reduce the time limit by modifying the constant REDUCED_TIME_LIMIT_MS.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: VT20-2257

Testing & Validation

  • This PR has been tested/validated in iOS, Android and browser.
  • Added new unit tests, if relevant.

Design Review

  • In case this PR contains changes to the UI, add some screenshots and/or videos to show the changes on relevant devices.

IOS

Screenshot 2025-12-02 at 16 57 40

Android

Image

Open modal when open app

Screen.Recording.2025-12-02.at.17.25.31.mov

When the user attempts to perform a critical action.

Screen.Recording.2025-12-02.at.17.15.43.mov

@Sotatek-DukeVu Sotatek-DukeVu removed the request for review from sdisalvo-crd December 3, 2025 03:09
@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Dec 3, 2025
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the VT20-2257-verify-seed-phrase-limit-reached branch from 6e15551 to 773fac8 Compare December 3, 2025 03:10
@Sotatek-DukeVu Sotatek-DukeVu force-pushed the VT20-2257-verify-seed-phrase-limit-reached branch from 4656411 to 676fb95 Compare December 3, 2025 09:46
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find where you are counting the critical actions and where the timer is.

I did some tests and I was able to initiate a group profile, receive 5 credentials and fulfill a presentation request and had no issues at all. Also in your video the screen is showing up after the user creates 5 individual profiles, on which we have no limits upon. I think you may have misunderstood the acceptance criteria.

Could you please read through the full ticket description again and amend these changes?

@iFergal
Copy link
Collaborator

iFergal commented Dec 3, 2025

@sdisalvo-crd After 5 actions, the timer is reduced to 1 day - this was the agreed approach and is in the ticket but I think there are some conflicting ACs. This is all handled by the core.

If you want to test this locally, it might be easier to temporarily change Agent.REDUCED_TIME_LIMIT_MS to 2 minutes or something.

@iFergal
Copy link
Collaborator

iFergal commented Dec 3, 2025

During the review period with Jaime, we also decided to count identifier creation as an action, even though it doesn't build reputation. I'm in two minds about that one.

@Sotatek-DukeVu
Copy link
Collaborator Author

I can't find where you are counting the critical actions and where the timer is.

I did some tests and I was able to initiate a group profile, receive 5 credentials and fulfill a presentation request and had no issues at all. Also in your video the screen is showing up after the user creates 5 individual profiles, on which we have no limits upon. I think you may have misunderstood the acceptance criteria.

Could you please read through the full ticket description again and amend these changes?

I added new description.

@sdisalvo-crd
Copy link
Contributor

sdisalvo-crd commented Dec 3, 2025

After 5 actions, the timer is reduced to 1 day - this was the agreed approach and is in the ticket but I think there are some conflicting ACs. This is all handled by the core.

If you want to test this locally, it might be easier to temporarily change Agent.REDUCED_TIME_LIMIT_MS to 2 minutes or something.

Thanks for clarifying that @iFergal I didn't remember those details, so just by reading the ticket description and A/C and watching the video I thought things would work differently.

In the ticket it says:

If the user reaches the time limit of two weeks or performs five critical actions without verifying their seed phrase:
A modal appears prompting the user to verify their seed phrase.

My understanding of that is they should see the modal right away after the 5th action. What should we do then instead? Allowing them to keep doing stuff and only show the modal 1 day after?

If you think we should count also single identifier creation then we should add it to the ticket. CC: @jorgenavben

@sdisalvo-crd
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants