-
Notifications
You must be signed in to change notification settings - Fork 27
feat(ui): Verify Seed Phrase - Limit reached #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(ui): Verify Seed Phrase - Limit reached #1464
Conversation
6e15551 to
773fac8
Compare
4656411 to
676fb95
Compare
sdisalvo-crd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find where you are counting the critical actions and where the timer is.
I did some tests and I was able to initiate a group profile, receive 5 credentials and fulfill a presentation request and had no issues at all. Also in your video the screen is showing up after the user creates 5 individual profiles, on which we have no limits upon. I think you may have misunderstood the acceptance criteria.
Could you please read through the full ticket description again and amend these changes?
|
@sdisalvo-crd After 5 actions, the timer is reduced to 1 day - this was the agreed approach and is in the ticket but I think there are some conflicting ACs. This is all handled by the core. If you want to test this locally, it might be easier to temporarily change |
|
During the review period with Jaime, we also decided to count identifier creation as an action, even though it doesn't build reputation. I'm in two minds about that one. |
I added new description. |
Thanks for clarifying that @iFergal I didn't remember those details, so just by reading the ticket description and A/C and watching the video I thought things would work differently. In the ticket it says:
My understanding of that is they should see the modal right away after the 5th action. What should we do then instead? Allowing them to keep doing stuff and only show the modal 1 day after? If you think we should count also single identifier creation then we should add it to the ticket. CC: @jorgenavben |

Description
This PR handles the requirement that users must verify their seed phrase after performing five critical actions or after two weeks since the wallet was initialized.
The recording of critical actions and the checking of the time limit are already handled by the core. Currently, we need to catch the
Agent.SEED_PHRASE_NOT_VERIFIEDerror or check the result of the functionAgent.agent.isVerificationEnforced.Here, after the user performs 5 critical actions, the remaining time is reduced to 1 day, and once this time is reached, a modal will appear requiring the user to verify their seed phrase.
To test this function, you can reduce the time limit by modifying the constant
REDUCED_TIME_LIMIT_MS.Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
IOS
Android
Open modal when open app
Screen.Recording.2025-12-02.at.17.25.31.mov
When the user attempts to perform a critical action.
Screen.Recording.2025-12-02.at.17.15.43.mov