Skip to content

Commit 7f6947d

Browse files
Fix upgrade on leader unit after resume-upgrade (#132)
If `resume-upgrade` ran and leader was 2nd highest unit, it would not upgrade on the same event Leftover from k8s where reconcile_partition triggers upgrade of unit (and Juju event) automatically
1 parent f393200 commit 7f6947d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/machine_charm.py

+5
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ def _on_upgrade_charm(self, _) -> None:
8787
# Only call `reconcile` on leader unit to avoid race conditions with `upgrade_resumed`
8888
self.reconcile()
8989

90+
def _on_resume_upgrade_action(self, event: ops.ActionEvent) -> None:
91+
super()._on_resume_upgrade_action(event)
92+
# If next to upgrade, upgrade leader unit
93+
self.reconcile()
94+
9095
def _on_force_upgrade_action(self, event: ops.ActionEvent) -> None:
9196
if not self._upgrade or not self._upgrade.in_progress:
9297
message = "No upgrade in progress"

0 commit comments

Comments
 (0)