[DPE-8923] Migrate tests/integration/integration/{relations,roles} to Jubilant #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Libraries: Out of sync
paulomach
previously approved these changes
Nov 26, 2025
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
lgtm - not sure what's going on with arm runners though
Contributor
sinclert-canonical
left a comment
sinclert-canonical
left a comment
There was a problem hiding this comment.
Thanks! Left a bunch of comment.
astrojuanlu
force-pushed
the
juanlu/migrate-database-tests
branch
2 times, most recently
from
20d586f to
16622b4
Compare
astrojuanlu
commented
Nov 28, 2025
Contributor
sinclert-canonical
left a comment
sinclert-canonical
left a comment
There was a problem hiding this comment.
Provided 2nd round of review.
paulomach
previously approved these changes
Dec 2, 2025
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
Address Sinclert's notes and we are good to go
Make tests async where appropriate.
This reverts commit 7d0ad49.
astrojuanlu
force-pushed
the
juanlu/migrate-database-tests
branch
from
c5f4c88 to
9ab474c
Compare
sinclert-canonical
approved these changes
Dec 3, 2025
Contributor
sinclert-canonical
left a comment
sinclert-canonical
left a comment
There was a problem hiding this comment.
Thanks for addressing all the feedback!
I know most of my comments were is style / code-structure wise, but we must follow some standard when we organize the tests. Otherwise we will end up as we were a few months back: dumping everything into helpers.py.
paulomach
approved these changes
Dec 4, 2025
Contributor
|
@astrojuanlu I think you forgot to copy + paste code from the |
Contributor
Author
|
🤦🏼 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors canonical/mysql-k8s-operator#683
Checklist