Merge pull request #9 from ostrolucky/psalm

Add psalm and PHP 8.3 to CI

Author: bytes-commerce

.github/workflows/ci.yml

@@ -19,6 +19,7 @@ jobs:
           - "8.0"
           - "8.1"
           - "8.2"
+          - "8.3"
 
     steps:
       - name: "Checkout"
@@ -52,5 +53,8 @@ jobs:
       - name: "PhpStan for tests"
         run: "vendor/bin/phpstan analyse --error-format=checkstyle tests --level=6 | cs2pr"
 
+      - name: "Psalm"
+        run: "vendor/bin/psalm --output-format=github --php-version=${{ matrix.php-version }}"
+
       - name: "PHPUnit Test"
         run: "vendor/bin/phpunit tests/BaseTest.php"

composer.json

@@ -26,7 +26,9 @@
   "require-dev": {
     "phpstan/phpstan": "^1.10",
     "symplify/easy-coding-standard": "^11.3",
-    "phpunit/phpunit": "^9|^10"
+    "phpunit/phpunit": "^9|^10",
+    "vimeo/psalm": "^5.18",
+    "psalm/plugin-phpunit": "^0.18"
   },
   "autoload": {
     "psr-4": {

psalm.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="1"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    findUnusedCode="true"
+    findUnusedBaselineEntry="true"
+>
+    <projectFiles>
+        <directory name="src" />
+        <directory name="tests" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+    <plugins>
+        <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
+    </plugins>
+</psalm>

src/ConsecutiveParams.php

@@ -12,14 +12,14 @@
 
 trait ConsecutiveParams
 {
-    /** @return list<Callback> */
+    /** @return \Generator<int, Callback> */
     public static function withConsecutive(array $firstCallArguments, array ...$consecutiveCallsArguments): iterable
     {
         foreach ($consecutiveCallsArguments as $consecutiveCallArguments) {
             TestCase::assertSameSize($firstCallArguments, $consecutiveCallArguments, 'Each expected arguments list need to have the same size.');
         }
 
-        $allConsecutiveCallsArguments = [$firstCallArguments, ...$consecutiveCallsArguments];
+        $allConsecutiveCallsArguments = [$firstCallArguments, ...array_values($consecutiveCallsArguments)];
 
         $numberOfArguments = count($firstCallArguments);
         $argumentList = [];
@@ -29,10 +29,11 @@ public static function withConsecutive(array $firstCallArguments, array ...$cons
 
         $mockedMethodCall = 0;
         $callbackCall = 0;
-        foreach ($argumentList as $index => $argument) {
+        foreach ($argumentList as $argument) {
             yield new Callback(
-                static function ($actualArgument) use ($argumentList, &$mockedMethodCall, &$callbackCall, $index, $numberOfArguments): bool {
-                    $expected = $argumentList[$index][$mockedMethodCall] ?? null;
+                static function ($actualArgument) use (&$mockedMethodCall, &$callbackCall, $argument, $numberOfArguments): bool {
+                    /** @var mixed $expected */
+                    $expected = $argument[$mockedMethodCall] ?? null;
 
                     ++$callbackCall;
                     $mockedMethodCall = (int) ($callbackCall / $numberOfArguments);

tests/BaseTest.php

@@ -9,20 +9,13 @@
 
 final class TestableClass
 {
-    public function foo(object $testClass): void
+    public function foo(InputInterface $testClass): void
     {
         $testClass->setSomething(1);
         $testClass->setSomething(2);
     }
 }
 
-final class InputClass implements InputInterface
-{
-    public function setSomething(int $i): void
-    {
-    }
-}
-
 interface InputInterface
 {
     public function setSomething(int $i): void;