fix: Fixes assigning a constant string to a local array

For a local array (parameter ByRef, or locally declared) the
assignation of a constant string value to an array element was
broken.

Author: boriel

src/arch/z80/backend/_array.py

@@ -313,8 +313,8 @@ def _astoref(ins: Quad) -> list[str]:
 
 def _astorestr(ins: Quad) -> list[str]:
     """Stores a string value into a memory address.
-    It copies content of 2nd operand (string), into 1st, reallocating
-    dynamic memory for the 1st str. These instruction DOES ALLOW
+    It copies the content of the 2nd operand (string), into 1st, reallocating
+    dynamic memory for the 1st str. These instructions DO ALLOW
     immediate strings for the 2nd parameter, starting with '#'.
     """
     output = _addr(ins[1])

src/arch/z80/backend/_parray.py

@@ -289,17 +289,20 @@ def _pastorestr(ins: Quad) -> list[str]:
     immediate strings for the 2nd parameter, starting with '#'.
     """
     output = _paddr(ins[1])
-    temporal = False
     value = ins[2]
 
     indirect = value[0] == "*"
     if indirect:
         value = value[1:]
 
-    immediate = value[0]
+    immediate = value[0] == "#"
     if immediate:
         value = value[1:]
 
+    temporal = not immediate and value[0] != "$"
+    if temporal:
+        value = value[1:]
+
     if value[0] == "_":
         if indirect:
             if immediate:
@@ -313,8 +316,10 @@ def _pastorestr(ins: Quad) -> list[str]:
             else:
                 output.append("ld de, (%s)" % value)
     else:
-        output.append("pop de")
-        temporal = True
+        if immediate:
+            output.append("ld de, %s" % value)
+        else:
+            output.append("pop de")
 
         if indirect:
             output.append(runtime_call(RuntimeLabel.LOAD_DE_DE))

src/symbols/id_/ref/varref.py

@@ -39,7 +39,7 @@ def t(self) -> str:
         if self.parent.type_ is None or not self.parent.type_.is_dynamic:
             return self._t
 
-        return f"${self._t}"  # Local string variables (and parameters) use '$' (see backend)
+        return f"${self._t}"  # Local string variables (and ByVal parameters) use '$' (see backend)
 
     @property
     def size(self) -> int:

src/zxbc/zxbparser.py

@@ -1198,7 +1198,8 @@ def p_arr_assignment(p):
 
     if entry.type_ == TYPE.string:
         variable = gl.SYMBOL_TABLE.access_array(id_, p.lineno(i))
-        if len(variable.ref.bounds) + 1 == len(arg_list):
+        # variable is an array. If it has 0 bounds means they are undefined (param byref)
+        if len(variable.ref.bounds) and len(variable.ref.bounds) + 1 == len(arg_list):
             ss = arg_list.children.pop().value
             p[0] = make_array_substr_assign(p.lineno(i), id_, arg_list, (ss, ss), expr)
             return