Use events instead of calling child widgets

Author: m3nu

src/vorta/application.py

@@ -42,6 +42,7 @@ class VortaApp(QtSingleApplication):
     backup_log_event = QtCore.pyqtSignal(str, dict)
     backup_progress_event = QtCore.pyqtSignal(str)
     check_failed_event = QtCore.pyqtSignal(dict)
+    profile_changed_event = QtCore.pyqtSignal()
 
     def __init__(self, args_raw, single_app=False):
         super().__init__(str(APP_ID), args_raw)

src/vorta/views/archive_tab.py

@@ -152,6 +152,8 @@ def __init__(self, parent=None, app=None):
 
         # Connect to palette change
         self.app.paletteChanged.connect(lambda p: self.set_icons())
+        self.app.profile_changed_event.connect(self.populate_from_profile)
+        self.app.profile_changed_event.connect(self.toggle_compact_button_visibility)
 
     def set_icons(self):
         """Used when changing between light- and dark mode"""

src/vorta/views/log_page.py

@@ -1,6 +1,7 @@
 from PyQt6 import uic
 from PyQt6.QtWidgets import (
     QAbstractItemView,
+    QApplication,
     QHeaderView,
     QTableWidgetItem,
 )
@@ -26,6 +27,7 @@ def __init__(self, parent=None):
         super().__init__(parent)
         self.setupUi(self)
         self.init_ui()
+        QApplication.instance().profile_changed_event.connect(self.populate_logs)
 
     def init_ui(self):
         self.logPage.setAlternatingRowColors(True)

src/vorta/views/main_window.py

@@ -185,14 +185,15 @@ def profile_selection_changed_action(self, index):
         if not backup_profile_id:
             return
         self.current_profile = BackupProfileModel.get(id=backup_profile_id)
-        self.archiveTab.populate_from_profile()
-        self.repoTab.populate_from_profile()
-        self.sourceTab.populate_from_profile()
-        self.scheduleTab.schedulePage.populate_from_profile()
+        self.app.profile_changed_event.emit()
+        # self.archiveTab.populate_from_profile()
+        # self.repoTab.populate_from_profile()
+        # self.sourceTab.populate_from_profile()
+        # self.scheduleTab.schedulePage.populate_from_profile()
         SettingsModel.update({SettingsModel.str_value: self.current_profile.id}).where(
             SettingsModel.key == 'previous_profile_id'
         ).execute()
-        self.archiveTab.toggle_compact_button_visibility()
+        # self.archiveTab.toggle_compact_button_visibility()
 
     def profile_clicked_action(self):
         if self.miscWidget.isVisible():
@@ -262,11 +263,12 @@ def profile_imported_event(profile):
                 self.tr('Profile import successful!'),
                 self.tr('Profile {} imported.').format(profile.name),
             )
-            self.repoTab.populate_from_profile()
-            self.scheduleTab.logPage.populate_logs()
-            self.scheduleTab.networksPage.populate_wifi()
-            self.miscTab.populate()
+            # self.repoTab.populate_from_profile()
+            # self.scheduleTab.logPage.populate_logs()
+            # self.scheduleTab.networksPage.populate_wifi()
+            # self.miscTab.populate()
             self.populate_profile_selector()
+            self.app.profile_changed_event.emit()
 
         filename = QFileDialog.getOpenFileName(
             self,

src/vorta/views/misc_tab.py

@@ -46,6 +46,7 @@ def __init__(self, parent=None):
 
         # Connect to palette change
         QApplication.instance().paletteChanged.connect(lambda p: self.set_icons())
+        QApplication.instance().profile_changed_event.connect(self.populate)
 
     def populate(self):
         """

src/vorta/views/networks_page.py

@@ -1,6 +1,6 @@
 from PyQt6 import uic
 from PyQt6.QtCore import Qt
-from PyQt6.QtWidgets import QCheckBox, QLabel, QListWidget, QListWidgetItem
+from PyQt6.QtWidgets import QApplication, QCheckBox, QLabel, QListWidget, QListWidgetItem
 
 from vorta.store.models import BackupProfileMixin, WifiSettingModel
 from vorta.utils import get_asset, get_sorted_wifis
@@ -20,6 +20,8 @@ def __init__(self, parent=None):
 
         self.populate_wifi()
         self.setup_connections()
+        QApplication.instance().profile_changed_event.connect(self.populate_wifi)
+        QApplication.instance().profile_changed_event.connect(self.setup_connections)
 
     def setup_connections(self):
         self.meteredNetworksCheckBox.stateChanged.connect(self.on_metered_networks_state_changed)

src/vorta/views/repo_tab.py

@@ -63,11 +63,11 @@ def __init__(self, parent=None):
         self.bAddSSHKey.clicked.connect(self.create_ssh_key)
 
         self.set_icons()
+        self.populate_from_profile()  # needs init of ssh and compression items
 
-        # Connect to palette change
+        # Connect to events
         QApplication.instance().paletteChanged.connect(lambda p: self.set_icons())
-
-        self.populate_from_profile()  # needs init of ssh and compression items
+        QApplication.instance().profile_changed_event.connect(self.populate_from_profile)
 
     def set_icons(self):
         self.bAddSSHKey.setIcon(get_colored_icon("plus"))

src/vorta/views/schedule_page.py

@@ -64,6 +64,9 @@ def __init__(self, parent=None):
         self.app.scheduler.schedule_changed.connect(lambda pid: self.draw_next_scheduled_backup())
         self.populate_from_profile()
 
+        # Listen for events
+        self.app.profile_changed_event.connect(self.populate_from_profile)
+
     def on_scheduler_change(self, _):
         profile = self.profile()
         for label, obj in self.schedulerRadioMapping.items():

src/vorta/views/source_tab.py

@@ -106,13 +106,14 @@ def __init__(self, parent=None):
         self.bExclude.clicked.connect(self.show_exclude_dialog)
         header.sortIndicatorChanged.connect(self.update_sort_order)
 
-        # Connect to palette change
-        QApplication.instance().paletteChanged.connect(lambda p: self.set_icons())
-
         # Populate
         self.populate_from_profile()
         self.set_icons()
 
+        # Listen for events
+        QApplication.instance().paletteChanged.connect(lambda p: self.set_icons())
+        QApplication.instance().profile_changed_event.connect(self.populate_from_profile)
+
     def set_icons(self):
         "Used when changing between light- and dark mode"
         self.addButton.setIcon(get_colored_icon('plus'))