fix issues

- namespace comment hint
- dup() errno check
- fix call_at and time format issue

Author: philoinovsky

include/boost/python/eventloop.hpp

@@ -18,8 +18,7 @@ namespace boost { namespace python { namespace asio {
 class event_loop
 {
 public:
-    event_loop(boost::asio::io_context::strand& strand): 
-        _strand{strand}, _created_time{std::chrono::steady_clock::now()}
+    event_loop(const boost::asio::io_context::strand& strand): _strand{strand}
     {
         try
         {
@@ -51,7 +50,7 @@ class event_loop
 
     inline double time()
     {
-        return static_cast<std::chrono::duration<double>>(std::chrono::steady_clock::now() - _created_time).count();
+        return std::chrono::steady_clock::now().time_since_epoch().count();
     }
 
     inline void add_reader(int fd, object f)
@@ -125,7 +124,6 @@ class event_loop
     boost::asio::io_context::strand _strand;
     // read: key = fd * 2 + 0, write: key = fd * 2 + 1
     std::unordered_map<int, std::unique_ptr<boost::asio::posix::stream_descriptor>> _descriptor_map;
-    std::chrono::steady_clock::time_point _created_time;
 
     inline int _read_key(int fd)
     {
@@ -161,7 +159,7 @@ class event_loop
     static void _sock_accept(event_loop& loop, object fut, object sock);
 };
 
-}}}
+}}} // namespace boost::python
 
 
 # endif

src/eventloop.cpp

@@ -9,6 +9,7 @@
 // 3. _ensure_fd_no_transport
 // 4. _ensure_resolve
 
+#include <errno.h>
 #include <iostream>
 #include <boost/asio.hpp>
 #include <boost/bind.hpp>
@@ -27,8 +28,14 @@ bool _hasattr(object o, const char* name)
     return PyObject_HasAttrString(o.ptr(), name);
 }
 
+void raise_dup_error()
+{
+    PyErr_SetString(PyExc_OSError, std::system_category().message(errno).c_str());
+    throw_error_already_set();
 }
 
+} // namespace
+
 void event_loop::_sock_connect_cb(object pymod_socket, object fut, object sock, object addr)
 {
     try 
@@ -100,30 +107,27 @@ void event_loop::call_later(double delay, object f)
 {
     auto p_timer = std::make_shared<boost::asio::steady_timer>(
         _strand.context(),
-        std::chrono::nanoseconds(int64_t(delay * 1e9)));
+        std::chrono::duration_cast<std::chrono::nanoseconds>(std::chrono::duration<double>(delay)));
     p_timer->async_wait(boost::asio::bind_executor(_strand,
-        [f, p_timer, this] (const boost::system::error_code& ec) {f();}));
+        [f, p_timer] (const boost::system::error_code& ec) {f();}));
 }
 
 void event_loop::call_at(double when, object f)
 {
-    double diff = when - time();
-    if (diff > 0)
-    {
-        auto p_timer = std::make_shared<boost::asio::steady_timer>(
-            _strand.context(),
-            std::chrono::nanoseconds(int64_t(diff * 1e9)));
-        p_timer->async_wait(boost::asio::bind_executor(_strand, 
-            [f, p_timer, this] (const boost::system::error_code& ec) {f();}));
-        return;
-    }
-    call_soon(f);
+    using sc = std::chrono::steady_clock;
+    auto p_timer = std::make_shared<boost::asio::steady_timer>(
+        _strand.context(),
+        sc::duration(static_cast<sc::time_point::rep>(when)));
+    p_timer->async_wait(boost::asio::bind_executor(_strand, 
+        [f, p_timer] (const boost::system::error_code& ec) {f();}));
 }
 
 object event_loop::sock_recv(object sock, size_t nbytes)
 {
     int fd = extract<int>(sock.attr("fileno")());
     int fd_dup = dup(fd);
+    if (fd_dup == -1)
+        raise_dup_error();
     object py_fut = _py_wrap_future(_pymod_concurrent_future.attr("Future")());
     _async_wait_fd(fd_dup, 
         [py_fut, nbytes, fd=fd_dup] {
@@ -139,6 +143,8 @@ object event_loop::sock_recv_into(object sock, object buffer)
 {
     int fd = extract<int>(sock.attr("fileno")());
     int fd_dup = dup(fd);
+    if (fd_dup == -1)
+        raise_dup_error();
     ssize_t nbytes = len(buffer);
     object py_fut = _py_wrap_future(_pymod_concurrent_future.attr("Future")());
     _async_wait_fd(fd_dup, 
@@ -155,6 +161,8 @@ object event_loop::sock_sendall(object sock, object data)
 {
     int fd = extract<int>(sock.attr("fileno")());
     int fd_dup = dup(fd);
+    if (fd_dup == -1)
+        raise_dup_error();
     char const* py_str = extract<char const*>(data.attr("decode")());
     ssize_t py_str_len = len(data);
     object py_fut = _py_wrap_future(_pymod_concurrent_future.attr("Future")());
@@ -187,7 +195,10 @@ object event_loop::sock_connect(object sock, object address)
             || PyErr_ExceptionMatches(PyExc_InterruptedError))
         {
             PyErr_Clear();
-            _async_wait_fd(dup(fd), bind(_sock_connect_cb, _pymod_socket, py_fut, sock, address), _write_key(fd));
+            int fd_dup = dup(fd);
+            if (fd_dup == -1)
+                raise_dup_error();
+            _async_wait_fd(fd_dup, bind(_sock_connect_cb, _pymod_socket, py_fut, sock, address), _write_key(fd));
         }
         else if (PyErr_ExceptionMatches(PyExc_SystemExit)
             || PyErr_ExceptionMatches(PyExc_KeyboardInterrupt))
@@ -388,4 +399,4 @@ void event_loop::call_exception_handler(object context)
 }
 
 
-}}}
+}}} // namespace boost::python