Skip to content

Commit b3f0fb4

Browse files
committed
Fixed #159, change types to general set as much as possible
1 parent 970890b commit b3f0fb4

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

src/java/boa/aggregators/SetAggregator.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package boa.aggregators;
1818

1919
import java.io.IOException;
20+
import java.util.Set;
2021
import java.util.LinkedHashSet;
2122

2223
import boa.io.EmitKey;
@@ -28,7 +29,7 @@
2829
*/
2930
@AggregatorSpec(name = "set", canCombine = true)
3031
public class SetAggregator extends Aggregator {
31-
private LinkedHashSet<String> set;
32+
private Set<String> set;
3233
private final long max;
3334

3435
/**

src/java/boa/graphs/cfg/CFGNode.java

+13-12
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package boa.graphs.cfg;
1818

1919
import java.util.HashMap;
20+
import java.util.Set;
2021
import java.util.LinkedHashSet;
2122

2223
import boa.types.Ast.Expression;
@@ -41,7 +42,7 @@ public class CFGNode implements Comparable<CFGNode> {
4142
private int objectNameId;
4243
private int classNameId;
4344
private int numOfParameters = 0;
44-
private LinkedHashSet<Integer> parameters;
45+
private Set<Integer> parameters;
4546
private int kind = TYPE_OTHER;
4647
private String pid;
4748
private Statement stmt;
@@ -52,8 +53,8 @@ public class CFGNode implements Comparable<CFGNode> {
5253
public static HashMap<String, Integer> idOfLabel = new HashMap<String, Integer>();
5354
public static HashMap<Integer, String> labelOfID = new HashMap<Integer, String>();
5455

55-
public LinkedHashSet<CFGEdge> inEdges = new LinkedHashSet<CFGEdge>();
56-
public LinkedHashSet<CFGEdge> outEdges = new LinkedHashSet<CFGEdge>();
56+
public Set<CFGEdge> inEdges = new LinkedHashSet<CFGEdge>();
57+
public Set<CFGEdge> outEdges = new LinkedHashSet<CFGEdge>();
5758

5859
public java.util.ArrayList<CFGNode> predecessors = new java.util.ArrayList<CFGNode>();
5960
public java.util.ArrayList<CFGNode> successors = new java.util.ArrayList<CFGNode>();
@@ -84,7 +85,7 @@ public CFGNode(String methodName, int kind, String className,
8485
}
8586

8687
public CFGNode(String methodName, int kind, String className,
87-
String objectName, int numOfParameters, LinkedHashSet<Integer> datas) {
88+
String objectName, int numOfParameters, Set<Integer> datas) {
8889
this.id = ++numOfNodes;
8990
this.methodId = convertLabel(methodName);
9091
this.kind = kind;
@@ -114,8 +115,8 @@ public Statement getStmt() {
114115
return this.stmt;
115116
}
116117

117-
public LinkedHashSet<String> getDefUse() {
118-
LinkedHashSet<String> defUse = new LinkedHashSet<String>(useVariables);
118+
public Set<String> getDefUse() {
119+
Set<String> defUse = new LinkedHashSet<String>(useVariables);
119120
defUse.add(defVariables);
120121
return defUse;
121122
}
@@ -182,11 +183,11 @@ public int getNumOfParameters() {
182183
return numOfParameters;
183184
}
184185

185-
public void setParameters(LinkedHashSet<Integer> parameters) {
186+
public void setParameters(Set<Integer> parameters) {
186187
this.parameters = parameters;
187188
}
188189

189-
public LinkedHashSet<Integer> getParameters() {
190+
public Set<Integer> getParameters() {
190191
return parameters;
191192
}
192193

@@ -230,11 +231,11 @@ public boolean hasFalseBranch() {
230231
return false;
231232
}
232233

233-
public LinkedHashSet<CFGEdge> getInEdges() {
234+
public Set<CFGEdge> getInEdges() {
234235
return inEdges;
235236
}
236237

237-
public LinkedHashSet<CFGEdge> getOutEdges() {
238+
public Set<CFGEdge> getOutEdges() {
238239
return outEdges;
239240
}
240241

@@ -255,7 +256,7 @@ public void setSuccessors(java.util.ArrayList<CFGNode> successors) {
255256
}
256257

257258
public java.util.ArrayList<CFGNode> getInNodes() {
258-
LinkedHashSet<CFGNode> nodes = new LinkedHashSet<CFGNode>();
259+
Set<CFGNode> nodes = new LinkedHashSet<CFGNode>();
259260
for (CFGEdge e : inEdges)
260261
nodes.add(e.getSrc());
261262
java.util.ArrayList<CFGNode> pred = new java.util.ArrayList<CFGNode>(nodes);
@@ -264,7 +265,7 @@ public java.util.ArrayList<CFGNode> getInNodes() {
264265
}
265266

266267
public java.util.ArrayList<CFGNode> getOutNodes() {
267-
LinkedHashSet<CFGNode> nodes = new LinkedHashSet<CFGNode>();
268+
Set<CFGNode> nodes = new LinkedHashSet<CFGNode>();
268269
for (CFGEdge e : outEdges)
269270
nodes.add(e.getDest());
270271
java.util.ArrayList<CFGNode> succ = new java.util.ArrayList<CFGNode>(nodes);

0 commit comments

Comments
 (0)