pinMode input/output logic was reversed. Fixed #4

blemasle · blemasle · commit 346e14d2a558 · 2019-02-19T16:26:41.000+01:00
diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=MCP23017
-version=1.1.0
+version=1.1.1
 author=Bertrand Lemasle
 maintainer=Bertrand Lemasle
 sentence=MCP23017 I2C Port expander library.
diff --git a/src/MCP23017.cpp b/src/MCP23017.cpp
@@ -38,8 +38,8 @@ void MCP23017::pinMode(uint8_t pin, uint8_t mode)
 	}
 
 	iodir = readRegister(iodirreg);
-	if(mode == OUTPUT) iodir |= _BV(pin);
-	else iodir &= ~_BV(pin);
+	if(mode == OUTPUT) iodir &= ~_BV(pin);
+	else iodir |= _BV(pin);
 
 	writeRegister(iodirreg, iodir);
 }

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,8 @@ void MCP23017::pinMode(uint8_t pin, uint8_t mode)`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`iodir = readRegister(iodirreg);`
`41`		`- if(mode == OUTPUT) iodir \|= _BV(pin);`
`42`		`- else iodir &= ~_BV(pin);`
	`41`	`+ if(mode == OUTPUT) iodir &= ~_BV(pin);`
	`42`	`+ else iodir \|= _BV(pin);`
`43`	`43`
`44`	`44`	`writeRegister(iodirreg, iodir);`
`45`	`45`	`}`