From 95c4f0fe9b2ccabd1e5cb5a4bef65648733329f2 Mon Sep 17 00:00:00 2001 From: chang-ning Date: Thu, 3 Jun 2021 23:09:51 +0800 Subject: [PATCH 1/4] bump ws to 7.4.6 Signed-off-by: chang-ning --- package.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 1706a509..b9219ba6 100644 --- a/package.json +++ b/package.json @@ -64,17 +64,16 @@ "standard": "^14.3.1" }, "dependencies": { - "readline-promise": "^1.0.4", - "blessed": "^0.1.81", - "blessed-contrib": "^4.8.19", - "cli-table3": "^0.6.0", "bfx-api-node-models": "^1.2.1", "bfx-api-node-rest": "^3.0.8", "bfx-api-node-util": "^1.0.2", "bfx-api-node-ws1": "^1.0.0", "bignumber.js": "^9.0.0", + "blessed": "^0.1.81", + "blessed-contrib": "^4.8.19", "bluebird": "^3.5.1", "cbq": "0.0.1", + "cli-table3": "^0.6.0", "copy": "^0.3.2", "crc-32": "^1.2.0", "debug": "^4.1.1", @@ -83,8 +82,9 @@ "lossless-json": "^1.0.3", "p-iteration": "^1.1.8", "promise-throttle": "^1.0.1", + "readline-promise": "^1.0.4", "request": "^2.67.0", "request-promise": "^4.2.0", - "ws": "^7.2.1" + "ws": "^7.4.6" } } From 3c92bd7c628fa8ff13047cf729fec809a0bfb8df Mon Sep 17 00:00:00 2001 From: chang-ning Date: Wed, 5 Aug 2020 14:10:52 +0800 Subject: [PATCH 2/4] fix: parse a funding trade is incorrect Signed-off-by: chang-ning --- lib/transports/ws2.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/transports/ws2.js b/lib/transports/ws2.js index facba4d0..daa0d917 100644 --- a/lib/transports/ws2.js +++ b/lib/transports/ws2.js @@ -979,13 +979,12 @@ class WSv2 extends EventEmitter { let data = payload if (this._transform) { // correctly parse single trade/array of trades - const M = eventName[0] === 'f' ? FundingTrade : PublicTrade - const trades = M.unserialize(data) + const M = eventName[0] === 'f' && data[0].length === 8 ? FundingTrade : PublicTrade - if (_isArray(trades) && trades.length === 1) { - data = trades[0] + if (_isArray(payload) && payload.length === 1) { + data = payload[0] } else { - data = trades + data = payload } data = new M(data) From a01405efe5f4a3fcc426d3a4983858ac57f4ef0b Mon Sep 17 00:00:00 2001 From: chang-ning Date: Wed, 5 Aug 2020 14:51:16 +0800 Subject: [PATCH 3/4] update CHANGELOG Signed-off-by: chang-ning --- CHANGELOG | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index f3a1b99b..cad5649c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,6 @@ +4.0.16 +- WSv2: fix parse funding trade failed. + 4.0.15 - fix 2 high vulnerabilities, switch from cli-table2 to cli-table3 dependency From c40fe072398114e0888fc0ca13cdf965195c7efc Mon Sep 17 00:00:00 2001 From: chang-ning Date: Wed, 5 Aug 2020 14:52:25 +0800 Subject: [PATCH 4/4] Bump version up to 4.0.16 Signed-off-by: chang-ning --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b9219ba6..cf4af787 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bitfinex-api-node", - "version": "4.0.15", + "version": "4.0.16", "description": "Node reference library for Bitfinex API", "engines": { "node": ">=8.3.0"