Improve performance?

[tischi]

Dear @tpietzsch,

Given the recent changes in ImgLib2, could you please have a quick look whether this code is optimal?

bigdataprocessor2/src/main/java/de/embl/cba/bdp2/utils/RAISlicer.java

Line 222 in 20f3f5a

RandomAccessibleInterval< R > copyVolumeRAI( RandomAccessibleInterval< R > volume, int numThreads, R type )

Thanks a lot for you help!

[tpietzsch]

I suspect it's not. I would recommend using BlockSupplier.
You can make a BlockSupplier for your source image using just BlockSupplier.of(volume).

This recently added method: https://github.com/imglib/imglib2-algorithm/blob/7355e0f5b7f6843d41ab9eea2fa0920c6e31e2f3/src/main/java/net/imglib2/algorithm/blocks/BlockAlgoUtils.java#L90-L111 copies data from a BlockSupplier into a new ArrayImg.

For the CellImg, you can use something like

Cell<?> cell = img.getCells().getAt(...cellPosition...);
Object destPrimitiveArray = ((ArrayDataAccess<?>) cell.getData()).getCurrentStorageArray();
blocks.copy(cell, destPrimitiveArray);

to fill a single cell.

blocks = blockSupplier.multiThreaded() gives you a version of the blocksupplier that you can use multi-threaded (to copy into multiple cells in parallel)