Can't find in non-utf8 files

[irudoy]

ACK can't find search_string in file with contents:

абвгдежз
search_string

(file encoding is Windows 1251)

ack "search_string" /path/to/dir/with/file -R ❌
grep "search_string" /path/to/dir/with/file -R ✅

If you delete one character from the first line, or the whole line, then everything will work.

ack 2.18
macOS 10.12.14

[Grian]

If we comment this line:

ack3/lib/App/Ack/Filter/Default.pm

Line 27 in ed82082

return -T $file->name;

and replace with "return 1"
it also will work.

also it is possible to work around the problem by using with type filters in command lines
for example

ack --type perl --type sql '<search_string>' <directory_or_none>

[Grian]

also possible partial workaround is

ack  --known-types '<search_string>' <directory_or_none>

[petdance]

ack's default behavior is to not look inside binary files. That's why the return -T $file->name is there.

Using Perl's -T operator is clearly not ideal, but I don't know of a better solution for distinguishing between text and non-text files.