import: Media type won't get updated when retagging album

[tuukkao]

Problem

When retagging an already imported album with a MusicBrainz release id with import -L -S <mbid> and the id used for importing has a different media type, the new media type won't get written.

Steps to reproduce:

1. Import an album from MusicBrainz that has releases in different formats (I tested with release c5292a70-ed3c-3bf3-b251-8a1e1e2abf23)

2. Retag the same album using a release with different media, for example:

   beet import -L -S "4429cdd4-b0dd-3e69-bc0c-fc521c998550" album:Mezmerize

3. Check the album's media:

   beet ls -a -f '$media' album:Mezmerize

   Media shows up as cd even though it should be 12" vinyl.

Setup

• OS: Windows 11
• Python version: 3.12.1
• beets version: 2.4.0
• Turning off plugins made problem go away (yes/no): no

My configuration (output of beet config) is:

directory: ~/mediabugtest/imported
# --------------- Main ---------------

library: ~/mediabugtest/library.db

import:
    write: yes
    move: no

# --------------- Plugins ---------------

plugins: musicbrainz
disabled_plugins: []
musicbrainz:
    search_limit: 5
    source_weight: 0.5
    host: musicbrainz.org
    https: no
    ratelimit: 1
    ratelimit_interval: 1
    genres: no
    external_ids:
        discogs: no
        bandcamp: no
        spotify: no
        deezer: no
        tidal: no
    extra_tags: []

[tuukkao]

I'm fairly sure retagging with a different media used to work some time before 2.3.0. I use a different naming scheme for sided (i.e. vinyl, cassette) and non-sided releases. When I imported my library to Beets I went through all my vinyl and cassette rips to make sure every release had the intended media type. Fixing the wrongly-detected ones with import -L -S used to work but it no longer does.

[snejus]

@tuukkao could you try and see whether this works using any other autotagger?

[tuukkao]

@tuukkao could you try and see whether this works using any other autotagger?

Doesn't seem to work with Discogs either. I tried with this release.

[semohr]

Adding 'media' to REIMPORT_FRESH_FIELDS_ALBUM seems to solve the issue.

Someone else wants to create a PR for this? I just quickly debugged this. There might be some implications I'm missing with the fix as this is quite deep in the core 🤷

Also I dont think this ever worked before, looking at the code and git history 🙃

[tuukkao]

Someone else wants to create a PR for this? I just quickly debugged this. There might be some implications I'm missing with the fix as this is quite deep in the core 🤷

I haven't contributed a line of code to Beets yet but I'd be happy to do the work if you think this wouldn't end up being a huge undertaking.

Also I dont think this ever worked before, looking at the code and git history 🙃

I'm fairly sure this has worked before in some way or another, but chances are I just ended up removing the album with beet rm -a and reimporting the files.

[semohr]

I haven't contributed a line of code to Beets yet but I'd be happy to do the work if you think this wouldn't end up being a huge undertaking.

We’re always happy to have more people on board! Smaller issues like this are a great place to start, and we’d really appreciate the help. We’re usually swamped with issues, so contributions really make the difference!

Feel free to ping me or drop me an email if you run into any trouble with the setup 🤞

[arsaboo]

Now that MB is another plugin, I'm pretty sure we will have to add all the other MB-fields to the list to be updated on re-import. This is what I have in my YouTube plugin:

def extend_reimport_fresh_fields_item():
    """Extend the REIMPORT_FRESH_FIELDS_ITEM list so that these fields
    are updated during reimport."""

    importer.REIMPORT_FRESH_FIELDS_ITEM.extend([
        'yt_album_id', 'yt_artist_id', 'yt_track_id',
        'yt_updated', 'yt_views'])

If no one gets to it, I'll create a PR for this.

[arsaboo]

@tuukkao can you try the fix in #6064

[tuukkao]

@tuukkao can you try the fix in #6064

This seems to work fine at least with MusicBrainz. I tried importing a 12" vinyl version of this release and then reimporting the CD release again and media was updated accordingly.

[arsaboo]

Excellent!!

@tuukkao, can you also check if the other fields (title, album, etc. ) are getting updated? Try reimporting with a wrong ID and then correct it.

[tuukkao]

@tuukkao, can you also check if the other fields (title, album, etc. ) are getting updated? Try reimporting with a wrong ID and then correct it.

Standard fields like title, album, year, track names etc. seem to get updated but track_alt doesn't. If I reimport a CD release with a 12" release and then reimport the CD again the lp track names are left behind from the previous import.