libffi.3.4.7.bcr.4 #5829
Draft
libffi.3.4.7.bcr.4 #5829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific settings, source overlay, and presubmit tasks
Member
|
Hello @feuerste, modules you maintain (libffi) have been updated in this PR. |
feuerste
suggested changes
Sep 10, 2025
Comment on lines
180
to
194
| cc_library( | ||
| name = "libffi", | ||
| visibility = ["//visibility:public"], | ||
| deps = select({ | ||
| ":windows_x86_32": [ | ||
| "@libffi-x86-32bit-msvc-binaries//:libffi", | ||
| ], | ||
| ":windows_x86_64": [ | ||
| "@libffi-x86-64bit-msvc-binaries//:libffi", | ||
| ], | ||
| "//conditions:default": [ | ||
| ":libffi-unix", | ||
| ], | ||
| }), | ||
| ) |
Contributor
There was a problem hiding this comment.
How about just using an alias instead?
alias(
name = "libffi",
visibility = ["//visibility:public"],
actual = select({
":windows_x86_32": [
"@libffi-x86-32bit-msvc-binaries//:libffi",
],
":windows_x86_64": [
"@libffi-x86-64bit-msvc-binaries//:libffi",
],
"//conditions:default": [
":libffi-unix",
],
}),
)
| """, | ||
| sha256 = "3f218abf32c765a6229ecc04d83d67e90266025e3f79b752358771119d02d8fb", | ||
| strip_prefix = "", | ||
| urls = ["https://github.com/libffi/libffi/releases/download/v3.5.2/libffi-3.5.2-x86-64bit-msvc-binaries.zip"], |
Contributor
There was a problem hiding this comment.
This version doesn't match the module version. Please either use the corresponding version or update the module version.
Comment on lines
+12
to
+44
| http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( | ||
| name = "libffi-x86-64bit-msvc-binaries", | ||
| build_file_content = """ | ||
| cc_import( | ||
| name = "libffi", | ||
| hdrs = ["ffi.h","ffitarget.h"], | ||
| interface_library = "libffi-8.lib", | ||
| shared_library = "libffi-8.dll", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
| """, | ||
| sha256 = "3f218abf32c765a6229ecc04d83d67e90266025e3f79b752358771119d02d8fb", | ||
| strip_prefix = "", | ||
| urls = ["https://github.com/libffi/libffi/releases/download/v3.5.2/libffi-3.5.2-x86-64bit-msvc-binaries.zip"], | ||
| ) | ||
|
|
||
| http_archive( | ||
| name = "libffi-x86-32bit-msvc-binaries", | ||
| build_file_content = """ | ||
| cc_import( | ||
| name = "libffi", | ||
| hdrs = ["ffi.h","ffitarget.h"], | ||
| interface_library = "libffi-8.lib", | ||
| shared_library = "libffi-8.dll", | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
| """, | ||
| sha256 = "73dd4bcdd533fb7dc28758026f369c6b914a59f4e71e87ddb66beff973a267d2", | ||
| strip_prefix = "", | ||
| urls = ["https://github.com/libffi/libffi/releases/download/v3.5.2/libffi-3.5.2-x86-32bit-msvc-binaries.zip"], | ||
| ) |
Contributor
There was a problem hiding this comment.
It would be much preferred to build from source on Windows as well. How much effort would this be?
Contributor
Author
There was a problem hiding this comment.
I'll try to make it support Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add windows