Fix Bazel 8 linking issues for transitive dependencies

This commit addresses linking problems that arose with Bazel 8 where
transitive Swift and ObjC dependencies were not being properly linked.

Changes:
- objc_provider_utils.bzl: Return struct instead of None for dynamic
  frameworks in Bazel 8 to maintain framework information
- framework_middleman.bzl:
  - Add SwiftInfo collection and propagation
  - Collect libraries from ObjcInfo and add to CcInfo linking context
  - Handle .lo files (from alwayslink libraries) properly
  - Remove unsupported dynamic_framework_file from ObjcInfo in Bazel 8
  - Add toolchains to dep_middleman rule
- framework.bzl: Re-add .lo file collection (critical for alwayslink)

These changes ensure all transitive dependencies are properly included
in the linking phase, fixing "undefined symbols" errors.

Author: iMostfa

.bazelrc

@@ -7,9 +7,6 @@ build --spawn_strategy=local
 # Setup Xcode configuration.
 build --xcode_version_config=//:host_xcodes
 
-#build --experimental_strict_conflict_checks
-common --incompatible_disallow_empty_glob=false
-
 build --verbose_failures # Print the full command line for commands that failed
 build --test_output=errors # Prints log file output to the console on failure
 

release_notes.md

@@ -1,36 +1,36 @@
 """Framework rules"""
 
-load("//rules/framework:vfs_overlay.bzl", "VFSOverlayInfo", "make_vfsoverlay")
-load("//rules:features.bzl", "feature_names")
-load("//rules:library.bzl", "PrivateHeadersInfo", "apple_library")
-load("//rules:plists.bzl", "process_infoplists")
-load("//rules:providers.bzl", "AvoidDepsInfo", "FrameworkInfo")
-load("//rules:transition_support.bzl", "transition_support")
-load("//rules:utils.bzl", "is_bazel_7")
-load("//rules/internal:objc_provider_utils.bzl", "objc_provider_utils")
 load("@bazel_skylib//lib:partial.bzl", "partial")
 load("@bazel_skylib//lib:paths.bzl", "paths")
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain")
 load("@build_bazel_rules_apple//apple/internal:apple_product_type.bzl", "apple_product_type")
+load("@build_bazel_rules_apple//apple/internal:apple_toolchains.bzl", "AppleMacToolsToolchainInfo", "AppleXPlatToolsToolchainInfo")
 load("@build_bazel_rules_apple//apple/internal:features_support.bzl", "features_support")
 load("@build_bazel_rules_apple//apple/internal:linking_support.bzl", "linking_support")
 load("@build_bazel_rules_apple//apple/internal:outputs.bzl", "outputs")
 load("@build_bazel_rules_apple//apple/internal:partials.bzl", "partials")
 load("@build_bazel_rules_apple//apple/internal:platform_support.bzl", "platform_support")
 load("@build_bazel_rules_apple//apple/internal:processor.bzl", "processor")
+load("@build_bazel_rules_apple//apple/internal:providers.bzl", "AppleBundleInfo", "ApplePlatformInfo", "IosFrameworkBundleInfo", "new_applebundleinfo", "new_iosframeworkbundleinfo")
 load("@build_bazel_rules_apple//apple/internal:resource_actions.bzl", "resource_actions")
 load("@build_bazel_rules_apple//apple/internal:resources.bzl", "resources")
 load("@build_bazel_rules_apple//apple/internal:rule_support.bzl", "rule_support")
-load("@build_bazel_rules_apple//apple/internal:apple_toolchains.bzl", "AppleMacToolsToolchainInfo", "AppleXPlatToolsToolchainInfo")
 load("@build_bazel_rules_apple//apple/internal:swift_support.bzl", "swift_support")
-load("@build_bazel_rules_apple//apple/internal/utils:clang_rt_dylibs.bzl", "clang_rt_dylibs")
-load("@build_bazel_rules_apple//apple/internal:providers.bzl", "AppleBundleInfo", "ApplePlatformInfo", "IosFrameworkBundleInfo", "new_applebundleinfo", "new_iosframeworkbundleinfo")
-load("@build_bazel_rules_swift//swift:providers.bzl", "SwiftInfo", "create_clang_module_inputs", "create_swift_module_context", "create_swift_module_inputs")
-load("@build_bazel_rules_swift//swift:swift.bzl", "swift_clang_module_aspect")
 load(
     "@build_bazel_rules_apple//apple/internal/aspects:resource_aspect.bzl",
     "apple_resource_aspect",
 )
+load("@build_bazel_rules_apple//apple/internal/utils:clang_rt_dylibs.bzl", "clang_rt_dylibs")
+load("@build_bazel_rules_swift//swift:providers.bzl", "SwiftInfo", "create_clang_module_inputs", "create_swift_module_context", "create_swift_module_inputs")
+load("@build_bazel_rules_swift//swift:swift.bzl", "swift_clang_module_aspect")
+load("//rules:features.bzl", "feature_names")
+load("//rules:library.bzl", "PrivateHeadersInfo", "apple_library")
+load("//rules:plists.bzl", "process_infoplists")
+load("//rules:providers.bzl", "AvoidDepsInfo", "FrameworkInfo")
+load("//rules:transition_support.bzl", "transition_support")
+load("//rules:utils.bzl", "is_bazel_7")
+load("//rules/framework:vfs_overlay.bzl", "VFSOverlayInfo", "make_vfsoverlay")
+load("//rules/internal:objc_provider_utils.bzl", "objc_provider_utils")
 
 _APPLE_FRAMEWORK_PACKAGING_KWARGS = [
     "visibility",
@@ -356,7 +356,7 @@ def _get_framework_files(ctx, deps):
                 continue
 
             # collect binary files
-            if file.path.endswith(".a"):
+            if file.path.endswith(".a") or file.path.endswith(".lo"):
                 binaries_in.append(file)
 
             # collect swift specific files

rules/framework.bzl

@@ -1,5 +1,6 @@
 load("@bazel_skylib//lib:partial.bzl", "partial")
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain")
+load("@build_bazel_rules_swift//swift:swift.bzl", "SwiftInfo")
 load(
     "@build_bazel_rules_apple//apple/internal:providers.bzl",
     "AppleResourceInfo",
@@ -41,6 +42,7 @@ def _framework_middleman(ctx):
     dynamic_framework_providers = []
     apple_embeddable_infos = []
     cc_providers = []
+    swift_infos = []
     cc_toolchain = find_cpp_toolchain(ctx)
     cc_features = cc_common.configure_features(
         ctx = ctx,
@@ -64,6 +66,11 @@ def _framework_middleman(ctx):
                 resource_providers.append(lib_dep[AppleResourceInfo])
         if apple_common.Objc in lib_dep:
             objc_providers.append(lib_dep[apple_common.Objc])
+        if SwiftInfo in lib_dep:
+            swift_infos.append(lib_dep[SwiftInfo])
+            # Also ensure Swift's CcInfo is collected
+            if CcInfo in lib_dep and lib_dep not in cc_providers:
+                cc_providers.append(lib_dep[CcInfo])
         # Bazel 8 compatibility: Try both old and potential new provider names
         if hasattr(apple_common, "AppleDynamicFramework") and apple_common.AppleDynamicFramework in lib_dep:
             dynamic_frameworks.append(lib_dep)
@@ -79,16 +86,14 @@ def _framework_middleman(ctx):
                 _process_dep(lib_dep)
 
     # Here we only need to loop a subset of the keys
-    objc_provider_fields = objc_provider_utils.merge_objc_providers_dict(providers = objc_providers, merge_keys = [
-        "dynamic_framework_file",
-    ])
+    # In Bazel 8, dynamic_framework_file is not supported in ObjcInfo
+    # We'll handle it through CcInfo instead
+    objc_provider_fields = objc_provider_utils.merge_objc_providers_dict(providers = objc_providers, merge_keys = [])
 
     # Add the frameworks to the objc provider for Bazel <= 6
     dynamic_framework_provider = objc_provider_utils.merge_dynamic_framework_providers(dynamic_framework_providers)
-    if dynamic_framework_provider:
-        objc_provider_fields["dynamic_framework_file"] = depset(
-            transitive = [dynamic_framework_provider.framework_files, objc_provider_fields.get("dynamic_framework_file", depset([]))],
-        )
+    # Don't add dynamic_framework_file to ObjcInfo in Bazel 8 - it will be handled via CcInfo
+    
     objc_provider = apple_common.new_objc_provider(**objc_provider_fields)
 
     # Add the framework info to the cc info linking context for Bazel >= 7
@@ -115,6 +120,56 @@ def _framework_middleman(ctx):
     else:
         cc_info_provider = cc_common.merge_cc_infos(cc_infos = cc_providers)
 
+    # Bazel 8 compatibility: Collect libraries from ObjcInfo and add to CcInfo
+    # This ensures all libraries (including .lo files) are properly linked
+    additional_libraries = []
+    for objc_p in objc_providers:
+        # Collect regular libraries
+        if hasattr(objc_p, "library"):
+            additional_libraries.extend(objc_p.library.to_list())
+        # Collect force_load libraries (critical for alwayslink)
+        if hasattr(objc_p, "force_load_library"):
+            additional_libraries.extend(objc_p.force_load_library.to_list())
+        # Collect imported libraries
+        if hasattr(objc_p, "imported_library"):
+            additional_libraries.extend(objc_p.imported_library.to_list())
+        # Collect static framework files
+        if hasattr(objc_p, "static_framework_file"):
+            additional_libraries.extend(objc_p.static_framework_file.to_list())
+    
+    # If we found additional libraries not in CcInfo, add them
+    if additional_libraries:
+        # Create library_to_link for each additional library
+        libraries_to_link = []
+        for lib in additional_libraries:
+            # Check if it's a static library (.a or .lo)
+            if lib.path.endswith(".a") or lib.path.endswith(".lo"):
+                libraries_to_link.append(
+                    cc_common.create_library_to_link(
+                        actions = ctx.actions,
+                        cc_toolchain = cc_toolchain,
+                        feature_configuration = cc_features,
+                        static_library = lib,
+                        alwayslink = lib.path.endswith(".lo"),  # .lo files are alwayslink
+                    )
+                )
+        
+        if libraries_to_link:
+            additional_cc_info = CcInfo(
+                linking_context = cc_common.create_linking_context(
+                    linker_inputs = depset([
+                        cc_common.create_linker_input(
+                            owner = ctx.label,
+                            libraries = depset(libraries_to_link),
+                        ),
+                    ]),
+                ),
+            )
+            cc_info_provider = cc_common.merge_cc_infos(
+                direct_cc_infos = [additional_cc_info],
+                cc_infos = [cc_info_provider],
+            )
+
     providers = [
         cc_info_provider,
         objc_provider,
@@ -135,6 +190,13 @@ def _framework_middleman(ctx):
     if dynamic_framework_provider:
         providers.append(dynamic_framework_provider)
 
+    # Add SwiftInfo if there are Swift dependencies
+    if swift_infos:
+        # For now, just pass through the first SwiftInfo if it exists
+        # Proper merging of SwiftInfo is complex and would require swift_common.merge_swift_info
+        if len(swift_infos) > 0:
+            providers.append(swift_infos[0])
+    
     embed_info_provider = embeddable_info.merge_providers(apple_embeddable_infos)
     if embed_info_provider:
         providers.append(embed_info_provider)
@@ -238,13 +300,19 @@ def _get_lib_name(name):
 def _dep_middleman(ctx):
     objc_providers = []
     cc_providers = []
+    swift_infos = []
     avoid_libraries = {}
 
     def _collect_providers(lib_dep):
         if apple_common.Objc in lib_dep:
             objc_providers.append(lib_dep[apple_common.Objc])
         if CcInfo in lib_dep:
             cc_providers.append(lib_dep[CcInfo])
+        if SwiftInfo in lib_dep:
+            swift_infos.append(lib_dep[SwiftInfo])
+            # Ensure Swift's CcInfo is also collected
+            if CcInfo in lib_dep and lib_dep[CcInfo] not in cc_providers:
+                cc_providers.append(lib_dep[CcInfo])
 
     def _process_avoid_deps(avoid_dep_libs):
         for dep in avoid_dep_libs:
@@ -317,14 +385,72 @@ def _dep_middleman(ctx):
 
     # Construct the CcInfo provider, the linking information is used in Bazel >= 7.
     cc_info_provider = cc_common.merge_cc_infos(cc_infos = cc_providers)
+    
+    # Bazel 8 compatibility: Ensure all libraries from ObjcInfo are in CcInfo
+    # Collect libraries that might not be in CcInfo yet
+    all_libraries = []
+    for key in ["library", "force_load_library", "imported_library", "static_framework_file"]:
+        if key in objc_provider_fields:
+            libs = objc_provider_fields[key].to_list()
+            for lib in libs:
+                # Only add files, not basenames
+                if hasattr(lib, "path"):
+                    all_libraries.append(lib)
+    
+    # Add any missing libraries to CcInfo
+    if all_libraries:
+        cc_toolchain = find_cpp_toolchain(ctx)
+        cc_features = cc_common.configure_features(
+            ctx = ctx,
+            cc_toolchain = cc_toolchain,
+            requested_features = ctx.features,
+            unsupported_features = ctx.disabled_features,
+        )
+        
+        libraries_to_link = []
+        for lib in all_libraries:
+            if lib.path.endswith(".a") or lib.path.endswith(".lo"):
+                libraries_to_link.append(
+                    cc_common.create_library_to_link(
+                        actions = ctx.actions,
+                        cc_toolchain = cc_toolchain,
+                        feature_configuration = cc_features,
+                        static_library = lib,
+                        alwayslink = lib.path.endswith(".lo"),
+                    )
+                )
+        
+        if libraries_to_link:
+            additional_cc_info = CcInfo(
+                linking_context = cc_common.create_linking_context(
+                    linker_inputs = depset([
+                        cc_common.create_linker_input(
+                            owner = ctx.label,
+                            libraries = depset(libraries_to_link),
+                        ),
+                    ]),
+                ),
+            )
+            cc_info_provider = cc_common.merge_cc_infos(
+                direct_cc_infos = [additional_cc_info],
+                cc_infos = [cc_info_provider],
+            )
 
-    return [
+    providers = [
         cc_info_provider,
         objc_provider,
     ]
+    
+    # Add SwiftInfo if there are Swift dependencies
+    if swift_infos and len(swift_infos) > 0:
+        # Pass through the first SwiftInfo (simplified - may need proper merging)
+        providers.append(swift_infos[0])
+    
+    return providers
 
 dep_middleman = rule(
     implementation = _dep_middleman,
+    toolchains = use_cpp_toolchain(),
     attrs = {
         "deps": attr.label_list(
             cfg = transition_support.apple_platform_split_transition,

rules/internal/framework_middleman.bzl

@@ -46,8 +46,23 @@ def _merge_objc_providers(providers, transitive = []):
 def _merge_dynamic_framework_providers(dynamic_framework_providers):
     # Bazel 8 compatibility: Check if new_dynamic_framework_provider exists
     if not hasattr(apple_common, "new_dynamic_framework_provider"):
-        # In Bazel 8, return None if the provider doesn't exist
-        return None
+        # In Bazel 8, create a struct to carry framework information
+        # This will be used to pass framework files through the build
+        framework_files = []
+        framework_dirs = []
+        
+        for dep in dynamic_framework_providers:
+            if hasattr(dep, "framework_files"):
+                framework_files.extend(dep.framework_files.to_list())
+            if hasattr(dep, "framework_dirs"):
+                framework_dirs.extend(dep.framework_dirs.to_list())
+        
+        return struct(
+            framework_files = depset(framework_files),
+            framework_dirs = depset(framework_dirs),
+            objc = apple_common.new_objc_provider(),
+            cc_info = CcInfo(),
+        )
 
     fields = {}
     merge_keys = [