Drop language table

[argiepiano]

language.install creates a table named language that is never used, since Backdrop stores this information in config. Interestingly, this table is dropped during D7 upgrades by language_update_1002, only to be created anew by language_schema()!

Git blame says these lines (language_schema()) are ancient - pre-Backdrop. My guess is that they were overlooked when Backdrop was forked.

[quicksketch]

Sounds great! One less table. 😄

[quicksketch]

This looks like an easy issue. PR filed at backdrop/backdrop#5089

[argiepiano]

This WFM, but I want to slightly revise my initial description of the problem, since it's a bit more complex than I originally mentioned. I don't think this changes anything with he PR, but just in case...

• In clean Backdrop installs (where the update hooks don't run), before this PR, the language table was created by language_schema() when enabling language. This table seems unnecessary - so, the PR correctly removes language_schema() and the new update hook language_update_1004() drops it for previous installations
• For D7 upgrades, there is no language table initially. Instead, there is a table called languages, which is renamed and somewhat "trimmed" by update_prepare_language() in update.inc. Then, the update hook language_update_1002() drops it completely. Since language_schema() does not run during installation of the module (the module was already enabled in D7), then the language table ends up never being created again. So, when you upgrade a D7 site you will not end up with language or languages tables - they are correctly dropped and not created again (as I had wrongly said above).

So, in fact the PR is helpful only for older clean Backdrop installs that ended up with that unneeded language table.

[argiepiano]

Oops, I just realized that some tests are not passing. Back to NW.

EDIT: The test that's failing is looking for a language table. This may be a remnant of a time before this table was dropped completely in favor of language.settings.json.