diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bc22b135..ab3a23cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -322,11 +322,11 @@ jobs: - name: Install dependencies run: | choco install nasm strawberryperl - choco install gstreamer --version=1.16.2 - choco install gstreamer-devel --version=1.16.2 + choco install gstreamer --version=1.22.8 + choco install gstreamer-devel --version=1.22.8 - name: Build repository run: | - $env:Path += ";C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin" + $env:Path += ";C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\bin" cd C:\amazon-kinesis-video-streams-producer-sdk-cpp .github\build_windows.bat - name: Configure AWS Credentials @@ -338,7 +338,7 @@ jobs: role-duration-seconds: 10800 - name: Run tests run: | - $env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin' + $env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\lib;C:\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\bin' & "C:\amazon-kinesis-video-streams-producer-sdk-cpp\build\tst\producerTest.exe" arm64-cross-compilation: diff --git a/.gitignore b/.gitignore index 5f8d045a..f8c3cbe1 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,6 @@ cmake-build-debug/ cmake-build-release/ doc/ open-source/ -outputs tags dependency diff --git a/CMake/Dependencies/libkvscproducer-CMakeLists.txt b/CMake/Dependencies/libkvscproducer-CMakeLists.txt index c2005daf..a256a591 100644 --- a/CMake/Dependencies/libkvscproducer-CMakeLists.txt +++ b/CMake/Dependencies/libkvscproducer-CMakeLists.txt @@ -7,7 +7,7 @@ include(ExternalProject) # clone repo only ExternalProject_Add(libkvscproducer-download GIT_REPOSITORY https://github.com/awslabs/amazon-kinesis-video-streams-producer-c.git - GIT_TAG develop + GIT_TAG cmake-cleanup SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvscproducer-src" BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvscproducer-build" CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} diff --git a/CMakeLists.txt b/CMakeLists.txt index be5c863d..4ad2a330 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -68,11 +68,11 @@ endif() if(BUILD_DEPENDENCIES) if(NOT EXISTS ${KINESIS_VIDEO_OPEN_SOURCE_SRC}) - file(MAKE_DIRECTORY ${KINESIS_VIDEO_OPEN_SOURCE_SRC}/local) + file(MAKE_DIRECTORY ${KINESIS_VIDEO_OPEN_SOURCE_SRC}) endif() if (NOT OPEN_SRC_INSTALL_PREFIX) - set(OPEN_SRC_INSTALL_PREFIX ${KINESIS_VIDEO_OPEN_SOURCE_SRC}/local) + set(OPEN_SRC_INSTALL_PREFIX ${KINESIS_VIDEO_OPEN_SOURCE_SRC}) set(ENV{PKG_CONFIG_PATH} "$ENV{PKG_CONFIG_PATH}:${OPEN_SRC_INSTALL_PREFIX}/lib/pkgconfig") set(CMAKE_PREFIX_PATH ${CMAKE_PREFIX_PATH} ${OPEN_SRC_INSTALL_PREFIX}) @@ -97,11 +97,11 @@ endif() find_package(Threads) find_package(PkgConfig REQUIRED) -pkg_check_modules(KVSCPRODUCER libcproducer) -if(KVSCPRODUCER_FOUND) - set(OPEN_SRC_INCLUDE_DIRS ${OPEN_SRC_INCLUDE_DIRS} ${KVSCPRODUCER_INCLUDE_DIRS}) - link_directories(${KVSCPRODUCER_LIBRARY_DIRS}) -else() + pkg_check_modules(KVSCPRODUCER libcproducer) + if(KVSCPRODUCER_FOUND) + set(OPEN_SRC_INCLUDE_DIRS ${OPEN_SRC_INCLUDE_DIRS} ${KVSCPRODUCER_INCLUDE_DIRS}) + link_directories(${KVSCPRODUCER_LIBRARY_DIRS}) + else() set(DEPENDENCY_DOWNLOAD_PATH ${CMAKE_CURRENT_SOURCE_DIR}/dependency) if(NOT EXISTS ${DEPENDENCY_DOWNLOAD_PATH}) file(MAKE_DIRECTORY ${DEPENDENCY_DOWNLOAD_PATH}) @@ -123,10 +123,10 @@ message("LOG4CPLUS_INCLUDE_DIR is ${LOG4CPLUS_INCLUDE_DIR}") message("LOG4CPLUS_LIBRARIES is ${LOG4CPLUS_LIBRARIES}") if (WIN32) - if(EXISTS "C:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe") - set(PKG_CONFIG_EXECUTABLE "C:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe") + if(EXISTS "C:\\gstreamer\\1.0\\msvc_x86_64\\bin\\pkg-config.exe") + set(PKG_CONFIG_EXECUTABLE "C:\\gstreamer\\1.0\\msvc_x86_64\\bin\\pkg-config.exe") else() - set(PKG_CONFIG_EXECUTABLE "D:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe") + set(PKG_CONFIG_EXECUTABLE "D:\\gstreamer\\1.0\\msvc_x86_64\\bin\\pkg-config.exe") endif() endif() @@ -178,9 +178,6 @@ include_directories(${KINESIS_VIDEO_PRODUCER_CPP_SRC}/src/credential-providers) include_directories(${KINESIS_VIDEO_PRODUCER_CPP_SRC}/src/common) include_directories(${KINESIS_VIDEO_PRODUCER_CPP_SRC}/src/JNI/include) -include_directories(${LOG4CPLUS_INCLUDE_DIR}) - - install( DIRECTORY ${KINESIS_VIDEO_PRODUCER_CPP_SRC}/src DESTINATION .) @@ -194,7 +191,7 @@ endif() target_link_libraries( KinesisVideoProducer PUBLIC cproducer - ${LOG4CPLUS_LIBRARIES}) + ${LOG4CPLUS_LIBRARIES}) install( TARGETS KinesisVideoProducer @@ -228,7 +225,6 @@ if(BUILD_JNI) RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}") endif() - if(BUILD_GSTREAMER_PLUGIN) pkg_check_modules(GST_APP REQUIRED gstreamer-app-1.0) include_directories(${GST_APP_INCLUDE_DIRS}) diff --git a/README.md b/README.md index a2875a70..c59536c6 100644 --- a/README.md +++ b/README.md @@ -149,7 +149,7 @@ The equivalent for Windows is ```bat set GST_PLUGIN_PATH=%CD%\build -set PATH=%PATH%;%CD%\open-source\local\bin;%CD%\open-source\local\lib +set PATH=%PATH%;%CD%\open-source\bin;%CD%\open-source\lib ``` Now if you execute `gst-inspect-1.0 kvssink` you should get information on the plugin like