Skip to content

Commit 0d48fb8

Browse files
chore: upgrade dependencies, fix spotbugs errors (#271)
1 parent 8f3f4d5 commit 0d48fb8

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

pom.xml

+12-12
Original file line numberDiff line numberDiff line change
@@ -70,26 +70,26 @@
7070
<dependency>
7171
<groupId>software.amazon.awssdk</groupId>
7272
<artifactId>secretsmanager</artifactId>
73-
<version>2.20.93</version>
73+
<version>2.31.7</version>
7474
</dependency>
7575

7676
<dependency>
7777
<groupId>org.projectlombok</groupId>
7878
<artifactId>lombok</artifactId>
79-
<version>1.18.28</version>
79+
<version>1.18.36</version>
8080
<scope>provided</scope>
8181
</dependency>
8282

8383
<dependency>
8484
<groupId>com.fasterxml.jackson.core</groupId>
8585
<artifactId>jackson-databind</artifactId>
86-
<version>2.15.2</version>
86+
<version>2.18.3</version>
8787
</dependency>
8888

8989
<dependency>
9090
<groupId>com.github.spotbugs</groupId>
9191
<artifactId>spotbugs-annotations</artifactId>
92-
<version>4.7.3</version>
92+
<version>4.9.3</version>
9393
</dependency>
9494

9595
<dependency>
@@ -133,7 +133,7 @@
133133
<plugin>
134134
<groupId>org.apache.maven.plugins</groupId>
135135
<artifactId>maven-compiler-plugin</artifactId>
136-
<version>3.11.0</version>
136+
<version>3.14.0</version>
137137
<configuration>
138138
<source>11</source>
139139
<target>11</target>
@@ -143,7 +143,7 @@
143143
<plugin>
144144
<groupId>org.apache.maven.plugins</groupId>
145145
<artifactId>maven-source-plugin</artifactId>
146-
<version>3.3.0</version>
146+
<version>3.3.1</version>
147147
<executions>
148148
<execution>
149149
<id>attach-sources</id>
@@ -156,7 +156,7 @@
156156
<plugin>
157157
<groupId>org.apache.maven.plugins</groupId>
158158
<artifactId>maven-javadoc-plugin</artifactId>
159-
<version>3.5.0</version>
159+
<version>3.11.2</version>
160160
<executions>
161161
<execution>
162162
<id>attach-javadocs</id>
@@ -169,7 +169,7 @@
169169
<plugin>
170170
<groupId>org.apache.maven.plugins</groupId>
171171
<artifactId>maven-checkstyle-plugin</artifactId>
172-
<version>3.3.0</version>
172+
<version>3.6.0</version>
173173
<configuration>
174174
<configLocation>${basedir}/config/checkstyle/checkstyle.xml</configLocation>
175175
<consoleOutput>true</consoleOutput>
@@ -190,7 +190,7 @@
190190
<plugin>
191191
<groupId>com.github.spotbugs</groupId>
192192
<artifactId>spotbugs-maven-plugin</artifactId>
193-
<version>4.7.3.5</version>
193+
<version>4.9.3.0</version>
194194
<configuration>
195195
<effort>Max</effort>
196196
<threshold>Low</threshold>
@@ -209,7 +209,7 @@
209209
<plugin>
210210
<groupId>org.jacoco</groupId>
211211
<artifactId>jacoco-maven-plugin</artifactId>
212-
<version>0.8.10</version>
212+
<version>0.8.12</version>
213213
<executions>
214214
<execution>
215215
<goals>
@@ -236,7 +236,7 @@
236236
<plugin>
237237
<groupId>org.apache.maven.plugins</groupId>
238238
<artifactId>maven-gpg-plugin</artifactId>
239-
<version>3.1.0</version>
239+
<version>3.2.7</version>
240240
<executions>
241241
<execution>
242242
<id>sign-artifacts</id>
@@ -250,7 +250,7 @@
250250
<plugin>
251251
<groupId>org.sonatype.plugins</groupId>
252252
<artifactId>nexus-staging-maven-plugin</artifactId>
253-
<version>1.6.13</version>
253+
<version>1.7.0</version>
254254
<extensions>true</extensions>
255255
<configuration>
256256
<serverId>sonatype-nexus-staging</serverId>

src/main/java/com/amazonaws/secretsmanager/sql/AWSSecretsManagerDriver.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ protected AWSSecretsManagerDriver() {
133133
*
134134
* @param cache Secret cache to use to retrieve secrets
135135
*/
136-
@SuppressFBWarnings("MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR")
136+
@SuppressFBWarnings({"MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR", "CT_CONSTRUCTOR_THROW"})
137137
protected AWSSecretsManagerDriver(SecretCache cache) {
138138
this.secretCache = cache;
139139

@@ -147,6 +147,7 @@ protected AWSSecretsManagerDriver(SecretCache cache) {
147147
*
148148
* @param builder Builder used to instantiate cache
149149
*/
150+
@SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
150151
protected AWSSecretsManagerDriver(SecretsManagerClientBuilder builder) {
151152
this(new SecretCache(builder));
152153
}
@@ -157,6 +158,7 @@ protected AWSSecretsManagerDriver(SecretsManagerClientBuilder builder) {
157158
*
158159
* @param client AWS Secrets Manager client to instantiate cache
159160
*/
161+
@SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
160162
protected AWSSecretsManagerDriver(SecretsManagerClient client) {
161163
this(new SecretCache(client));
162164
}
@@ -167,6 +169,7 @@ protected AWSSecretsManagerDriver(SecretsManagerClient client) {
167169
*
168170
* @param cacheConfig Cache configuration to instantiate cache
169171
*/
172+
@SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
170173
protected AWSSecretsManagerDriver(SecretCacheConfiguration cacheConfig) {
171174
this(new SecretCache(cacheConfig));
172175
}
@@ -211,6 +214,7 @@ private static void shutdown(AWSSecretsManagerDriver driver) {
211214
*
212215
* @throws RuntimeException If the driver could not be registered.
213216
*/
217+
@SuppressFBWarnings("THROWS_METHOD_THROWS_RUNTIMEEXCEPTION")
214218
protected static void register(AWSSecretsManagerDriver driver) {
215219
try {
216220
DriverManager.registerDriver(driver, () -> shutdown(driver));
@@ -336,6 +340,7 @@ public boolean acceptsURL(String url) throws SQLException {
336340
* database.
337341
* @throws InterruptedException If there was an interruption during secret refresh.
338342
*/
343+
@SuppressFBWarnings("THROWS_METHOD_THROWS_RUNTIMEEXCEPTION")
339344
private Connection connectWithSecret(String unwrappedUrl, Properties info, String credentialsSecretId)
340345
throws SQLException, InterruptedException {
341346
int retryCount = 0;
@@ -373,6 +378,7 @@ private Connection connectWithSecret(String unwrappedUrl, Properties info, Strin
373378
}
374379

375380
@Override
381+
@SuppressFBWarnings("THROWS_METHOD_THROWS_RUNTIMEEXCEPTION")
376382
public Connection connect(String url, Properties info) throws SQLException {
377383
if (!acceptsURL(url)) {
378384
return null;

0 commit comments

Comments
 (0)