BasicReplicationTest nits (#277)

samliok · yacovm · web-flow · commit e4f274810c15 · 2025-10-14T17:59:30.000+02:00
* replication nit

* update

---------

Co-authored-by: yacovm &lt;yacovm@users.noreply.github.com&gt;
diff --git a/replication_test.go b/replication_test.go
@@ -67,11 +67,10 @@ func testReplication(t *testing.T, startSeq uint64, nodes []simplex.NodeID) {
 	// all blocks except the lagging node start at round startSeq, seq startSeq.
 	// lagging node starts at round 0, seq 0.
 	// this asserts that the lagging node catches up to the latest round
-	for i := 0; i <= int(startSeq); i++ {
-		for _, n := range net.Instances {
-			n.Storage.WaitForBlockCommit(uint64(startSeq))
-		}
+	for _, n := range net.Instances {
+		n.Storage.WaitForBlockCommit(startSeq)
 	}
+	assertEqualLedgers(t, net)
 }
 
 // TestReplicationAdversarialNode tests the replication process of a node that

Original file line number	Diff line number	Diff line change
`@@ -67,11 +67,10 @@ func testReplication(t *testing.T, startSeq uint64, nodes []simplex.NodeID) {`
`67`	`67`	`// all blocks except the lagging node start at round startSeq, seq startSeq.`
`68`	`68`	`// lagging node starts at round 0, seq 0.`
`69`	`69`	`// this asserts that the lagging node catches up to the latest round`
`70`		`- for i := 0; i <= int(startSeq); i++ {`
`71`		`- for _, n := range net.Instances {`
`72`		`- n.Storage.WaitForBlockCommit(uint64(startSeq))`
`73`		`- }`
	`70`	`+ for _, n := range net.Instances {`
	`71`	`+ n.Storage.WaitForBlockCommit(startSeq)`
`74`	`72`	`}`
	`73`	`+ assertEqualLedgers(t, net)`
`75`	`74`	`}`
`76`	`75`
`77`	`76`	`// TestReplicationAdversarialNode tests the replication process of a node that`