Skip to content

Commit 48fb7a2

Browse files
authored
Merge pull request #4250 from bgartzi/avoid-_get_qemu_version
Avoid calling env_process._get_qemu_version from test cases
2 parents 5705527 + 9c8acd8 commit 48fb7a2

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

qemu/tests/cpu_info_check.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import re
2-
31
from avocado.utils import process
4-
from virttest import cpu, env_process, error_context, utils_misc
2+
from virttest import cpu, env_process, error_context, utils_misc, utils_qemu
53
from virttest.utils_version import VersionInterval
64

75

@@ -45,9 +43,7 @@ def get_patterns(p_list):
4543
list(map(cpu_types.extend, list(cpu.CPU_TYPES.values())))
4644

4745
qemu_path = utils_misc.get_qemu_binary(params)
48-
qemu_version = env_process._get_qemu_version(qemu_path)
49-
match = re.search(r"[0-9]+\.[0-9]+\.[0-9]+(\-[0-9]+)?", qemu_version)
50-
host_qemu = match.group(0)
46+
host_qemu = utils_qemu.get_qemu_version(qemu_path)[0]
5147
remove_list_deprecated = params.get("remove_list_deprecated", "")
5248
if host_qemu in VersionInterval("[7.0.0-8, )") and remove_list_deprecated:
5349
params["remove_list"] = remove_list_deprecated

qemu/tests/thin_write_in_qemu_img_commit.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import json
2-
import re
32

4-
from virttest import data_dir, env_process, utils_misc, utils_numeric
3+
from virttest import data_dir, utils_misc, utils_numeric, utils_qemu
54
from virttest.qemu_io import QemuIOSystem
65
from virttest.qemu_storage import QemuImg
76
from virttest.utils_version import VersionInterval
@@ -44,9 +43,7 @@ def _qemu_io(img, cmd):
4443
def _verify_map_output(output):
4544
""" "Verify qemu map output."""
4645
qemu_path = utils_misc.get_qemu_binary(params)
47-
qemu_version = env_process._get_qemu_version(qemu_path)
48-
match = re.search(r"[0-9]+\.[0-9]+\.[0-9]+(\-[0-9]+)?", qemu_version)
49-
host_qemu = match.group(0)
46+
host_qemu = utils_qemu.get_qemu_version(qemu_path)[0]
5047
expected = {
5148
"length": int(utils_numeric.normalize_data_size(params["write_size"], "B")),
5249
"start": 0,

0 commit comments

Comments
 (0)