Skip to content

Conversation

@bcarry
Copy link

@bcarry bcarry commented Nov 21, 2025

IMCCE base URL was changed from
http://vo.imcce.fr
to
https://ssp.imcce.fr

The columns from the Miriade/ephemcc service have changed on the new server, and the documentation adapted

@bsipocz bsipocz added this to the 0.4.12 milestone Nov 21, 2025
@bsipocz
Copy link
Member

bsipocz commented Nov 21, 2025

Many of these are already done in #3286, but that PR got stuck on upstream issues.

@bcarry bcarry marked this pull request as draft November 21, 2025 16:51
@bcarry
Copy link
Author

bcarry commented Nov 21, 2025

the automatic checks are failing, but I don't see what can I do for these.
Any ideas? Help please :-)
Thanks

@bcarry bcarry marked this pull request as ready for review November 24, 2025 13:45
@mkelley
Copy link
Contributor

mkelley commented Dec 3, 2025

@bcarry it looks like a few issues. You can follow the links on each check to see a log of the tests which should help identify the failures:

  • Edit CHANGES.rst to include a summary of these changes following the format of the other entries.
  • Remove the whitespace on line 397 of core.py: astroquery/imcce/core.py:397:1: W293 blank line contains whitespace
  • Line 316 of core.py is trying to rename a "date" column to "epoch", but "date" does not exist.

@bcarry
Copy link
Author

bcarry commented Dec 5, 2025

Thanks @mkelley !

  • white space removed
  • info added on CHANGE.rst (my bad for not having done it)
  • I don't understand the date->epoch point:

@mkelley
Copy link
Contributor

mkelley commented Dec 5, 2025

Ah, it is the offline tests that are failing in astroquery/imcce/tests/test_miriade.py. They rely on the votable files in astroquery/imcce/tests/data Can you regenerate these files with the new service? They look like they were generated for 3552 for a single date, only varying coordtype according to the file name. The date doesn't seem to matter to the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants