Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

Conversation

@charlieblevins
Copy link

Thanks for astilectron!

I needed this change in order to support the AWS Cognito callback url scheme requirement (https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-app-idp-settings.html) to allow users to login to my app. Please let me know if you think it would be worth merging in.

@asticode
Copy link
Owner

Can you walk me through why you need this and what it's actually doing ?

@asticode asticode self-assigned this Apr 28, 2019
@charlieblevins
Copy link
Author

charlieblevins commented May 18, 2019

Apologies for the long delay.

One way to use the app:// scheme is to allow deep linking from a website on the internet to the electron application. For example, a website on the internet can execute the following javascript to send a user into the electron application:

// some code in a public web page on the internet
window.location.href = 'app:///home.html';

You could do the above with a file url, but there would be no way to make that path work for every user, as the full path to the electron application will be different for everyone.

My particular need is to send a user using my application to an external web page on the wide-area internet inside electron. When they complete a process (authentication) on that external web page, the web page navigates the user back into my application. This helps me by allowing me to delegate authentication to a third party, which saves me from having to build a completely custom authentication mechanism.

@adambrakhane
Copy link

Seems like a really nice feature to me, if you can make it work well. OAuth callbacks are one reason, but any astielectron app that also has a web page could benefit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants