Skip to content

Commit d9ba02c

Browse files
committed
Merge branch 'sfaizanh-3.0' into 3.0
2 parents d431dda + b9c7f6d commit d9ba02c

File tree

7 files changed

+25
-144
lines changed

7 files changed

+25
-144
lines changed

.gitignore

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ log.txt
1111
*.sublime-workspace
1212
.vscode/
1313
npm-debug.log*
14-
dist/*.js.map
15-
dist/*.d.ts
16-
dist/*.js
14+
dist/
1715

1816
.idea/
1917
.sass-cache/

.npmignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Node generated files
22
node_modules
3+
src
4+
demo
35
npm-debug.log
46
# OS generated files
57
Thumbs.db

demo/src/app/app.module.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@ export function myCustomAudioProviderFactory() {
2727
}
2828

2929
export function providers() {
30-
return [{provide: ErrorHandler, useClass: IonicErrorHandler}, SplashScreen, StatusBar];
30+
return [
31+
{provide: ErrorHandler, useClass: IonicErrorHandler},
32+
SplashScreen,
33+
StatusBar
34+
];
3135
}
3236
export function entryComponents() {
3337
return pages;
@@ -41,7 +45,7 @@ export function declarations() {
4145
imports: [
4246
BrowserModule,
4347
IonicModule.forRoot(MyApp),
44-
IonicAudioModule.forRoot({ provide: AudioProvider, useFactory: myCustomAudioProviderFactory }),
48+
IonicAudioModule.forRoot(),
4549
// or use custom function above to force a specific provider
4650
// { provide: AudioProvider, useFactory: myCustomAudioProviderFactory }
4751
],

dist/ionic-audio.scss

Lines changed: 0 additions & 82 deletions
This file was deleted.

dist/package.json

Lines changed: 0 additions & 44 deletions
This file was deleted.

package.json

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"name": "ionic-audio",
3-
"version": "3.0.1",
3+
"version": "3.0.2",
44
"description": "An audio player for Ionic 3 and Angular 4",
55
"main": "./dist/index.js",
66
"typings": "./dist/index.d.ts",
77
"scripts": {
8-
"prepublish": "tsc -p ./",
9-
"release": "npm run prepublish && npm publish",
8+
"build": "node_modules/.bin/ngc && copyfiles -u 1 ./src/*.scss ./dist",
9+
"release": "npm run build && npm publish",
1010
"test": "echo \"Error: no test specified\" && exit 1"
1111
},
1212
"devDependencies": {
@@ -18,16 +18,11 @@
1818
"@angular/http": "4.1.2",
1919
"@angular/platform-browser": "4.1.2",
2020
"@angular/platform-browser-dynamic": "4.1.2",
21-
"@ionic-native/core": "3.10.2",
22-
"@ionic-native/splash-screen": "3.10.2",
23-
"@ionic-native/status-bar": "3.10.2",
24-
"@ionic/storage": "2.0.1",
2521
"ionic-angular": "3.3.0",
26-
"ionicons": "3.0.0",
2722
"rxjs": "5.1.1",
28-
"sw-toolbox": "3.6.0",
2923
"zone.js": "0.8.11",
30-
"typescript": "2.3.3"
24+
"typescript": "2.3.3",
25+
"copyfiles": "^1.2.0"
3126
},
3227
"repository": {
3328
"type": "git",

src/ionic-audio.module.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {AudioTrackComponent} from './ionic-audio-track-component';
66
import {AudioTrackProgressComponent, AudioTrackProgressBarComponent} from './ionic-audio-track-progress-component';
77
import {AudioTrackPlayComponent} from './ionic-audio-track-play-component';
88
import {AudioTimePipe} from './ionic-audio-time-pipe';
9-
import {AudioProvider, CordovaMediaProvider, WebAudioProvider} from './ionic-audio-providers';
9+
import {AudioProvider, audioProviderFactory} from './ionic-audio-providers';
1010

1111
export function declarations() {
1212
return [
@@ -15,7 +15,15 @@ export function declarations() {
1515
AudioTrackProgressBarComponent,
1616
AudioTrackPlayComponent,
1717
AudioTimePipe
18-
]
18+
];
19+
}
20+
21+
export function providers(audioProvider?: any) {
22+
audioProvider = audioProvider || { provide: AudioProvider, useFactory: audioProviderFactory }
23+
24+
return [
25+
audioProvider
26+
];
1927
}
2028

2129
@NgModule({
@@ -33,7 +41,7 @@ export class IonicAudioModule {
3341
static forRoot(audioProvider?: any): ModuleWithProviders {
3442
return {
3543
ngModule: IonicAudioModule,
36-
providers: audioProvider
44+
providers: providers(audioProvider)
3745
};
3846
}
3947
}

0 commit comments

Comments
 (0)