fix upload of artifacts not working (because they were dirs 🤦‍♂️)

Author: umbynos

.github/workflows/release.yml

@@ -1,8 +1,5 @@
 name: Release
 
-env:
-  DIST_DIR: dist
-
 on:
   push:
     tags:
@@ -80,7 +77,7 @@ jobs:
     - name: upload artifacts
       uses: actions/upload-artifact@v2
       with:
-        name: clang-${{ matrix.config.name }}-${{ matrix.config.arch }}
+        name: clang_${{ matrix.config.name }}_${{ matrix.config.arch }}
         path: |
           ${{ needs.get-version.outputs.llvm-version }}${{ matrix.config.bindir }}/clangd${{ matrix.config.extension }}
           ${{ needs.get-version.outputs.llvm-version }}${{ matrix.config.bindir }}/clang-format${{ matrix.config.extension }}
@@ -146,28 +143,36 @@ jobs:
     - name: upload artifacts
       uses: actions/upload-artifact@v2
       with:
-        name: clang-${{ matrix.config.name }}-${{ matrix.config.arch }}
+        name: clang_${{ matrix.config.name }}_${{ matrix.config.arch }}
         path: |
           ${{ needs.get-version.outputs.llvm-version }}/build/bin/clangd*
           ${{ needs.get-version.outputs.llvm-version }}/build/bin/clang-format*
 
   create-release:
     runs-on: ubuntu-latest
-    needs: 
-      - build-linux
-      - build-win-mac
+    needs: [build-linux, build-win-mac, get-version]
 
     steps:
       - name: Download artifact
         uses: actions/download-artifact@v2
-        with:
-          path: ${{ env.DIST_DIR }}
+
+      - name: Prepare artifacts for the release
+        run: |
+          mkdir release
+          declare -a target_folders=("linux_amd64" "linux_386" "linux_arm64" "linux_arm" "darwin_amd64" "windows_386" "windows_amd64")
+          for folder in "${target_folders[@]}"
+          do
+            chmod -v +x clang_$folder/*
+            FILENAME=clang-${{ needs.get-version.outputs.tag }}-${folder}.tar.bz2
+            tar -cvjf $FILENAME clang_$folder/
+          done
+          mv -v clang*.tar.bz2 release/
 
       - name: Create Github Release and upload artifacts
         uses: ncipollo/release-action@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           draft: false
           # NOTE: "Artifact is a directory" warnings are expected and don't indicate a problem
-          # (all the files we need are in the DIST_DIR root)
-          artifacts: ${{ env.DIST_DIR }}/*
+          # (all the files we need are in the release folder root)
+          artifacts: release/*