Merge pull request #146 from architecture-building-systems/fix-installing-from-git

Fix installing from git

Author: reyery

electron/cea/env.mjs

@@ -32,10 +32,11 @@ const paths = {
 
 export const getMicromambaPath = (check = false) => {
   const _path = paths?.[process.platform]?.['micromamba'];
-  console.debug({ micromambaPath: _path });
 
-  if (_path == null || !existsSync(_path))
+  if (_path == null || !existsSync(_path)) {
+    console.debug({ micromambaPath: _path });
     throw new MicromambaError('Unable to find path to micromamba.');
+  }
 
   // Try running micromamba
   if (check) {
@@ -52,10 +53,11 @@ export const getMicromambaPath = (check = false) => {
 
 export const getCEARootPath = () => {
   const _path = paths?.[process.platform]?.['root'];
-  console.debug({ ceaPath: _path });
 
-  if (_path == null)
+  if (_path == null) {
+    console.debug({ ceaPath: _path });
     throw new CEAError('Unable to determine path to CEA environment.');
+  }
 
   return _path;
 };
@@ -80,7 +82,7 @@ export const getCEAenvVersion = async () => {
 export const checkCEAenv = async () => {
   try {
     await execAsync(
-      `"${getMicromambaPath(true)}" -r "${getCEARootPath()}" -n cea run cea --help`,
+      `"${getMicromambaPath(true)}" -r "${getCEARootPath()}" -n cea run cea --version`,
     );
   } catch (error) {
     console.error(error);
@@ -113,20 +115,16 @@ const installCEA = async (ceaVersion) => {
   // Install CEA to CEA env
   try {
     await new Promise((resolve, reject) => {
-      const child = spawn(
-        `"${getMicromambaPath()}"`,
-        [
-          '-r',
-          getCEARootPath(),
-          '-n',
-          'cea',
-          'run',
-          'pip',
-          'install',
-          `git+${ceaGitUrl}`,
-        ],
-        { shell: true },
-      );
+      const child = spawn(getMicromambaPath(), [
+        '-r',
+        getCEARootPath(),
+        '-n',
+        'cea',
+        'run',
+        'pip',
+        'install',
+        `git+${ceaGitUrl}`,
+      ]);
 
       child.stdout.on('data', (data) => {
         console.debug(data.toString().trim());