gen-golden

Author: haasad

tests/golden/upgrade-notification/openshift4-console/openshift4-console/30_notification_rbac.yaml

@@ -2,8 +2,8 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    name: appuio-upgrade-notification-editor
-  name: appuio:upgrade-notification-editor
+    name: appuio-notification-manager
+  name: appuio:notification-manager
 rules:
   - apiGroups:
       - console.openshift.io
@@ -48,12 +48,12 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   labels:
-    name: appuio-upgrade-notification-manager
-  name: appuio:upgrade-notification-manager
+    name: appuio-notification-manager
+  name: appuio:notification-manager
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: appuio:upgrade-notification-editor
+  name: appuio:notification-manager
 subjects:
   - kind: ServiceAccount
     name: notification-manager

tests/golden/upgrade-notification/openshift4-console/openshift4-console/31_upgrade_notification.yaml

@@ -2,7 +2,8 @@ apiVersion: espejote.io/v1alpha1
 kind: ManagedResource
 metadata:
   annotations:
-    syn.tools/description: 'TODO: add description'
+    syn.tools/description: |
+      Creates ConsoleNotifications to inform cluster users about scheduled minor OpenShift upgrades.
   labels:
     app.kubernetes.io/name: minor-upgrade-notification
   name: minor-upgrade-notification
@@ -40,6 +41,8 @@ spec:
     local config = import 'minor-upgrade-notification/config.json';
     local dst = import 'minor-upgrade-notification/dst.json';
 
+    // Finds the next (i.e. "oldest") clusterversion overlay that sets a channel
+    // higher than the current OpenShift minor version.
     local nextChannelOverlay =
       local overlays = esp.context().clusterversion_appuio[0].spec.overlays;
       local current_minor = std.split(esp.context().clusterversion_ocp[0].spec.desiredUpdate.version, '.')[1];
@@ -53,10 +56,15 @@ spec:
         local next = std.sort(pendingOverlays)[0];
         {date: next[0], channel: next[1]};
 
+    // Finds the first upgrade window after the overlay date. Upgradeconfigs only
+    // display the next 10 maintenance windows, so it's not guaranteed to find one
+    // if the overlay is far in the future.
     local upgradeWindow = if nextChannelOverlay != null then
       local possible = [t.time for t in esp.context().upgradeconfig[0].status.nextPossibleSchedules if t.time > nextChannelOverlay.date ];
       if std.length(possible) > 0 then possible[0];
 
+    // Custom format datetime and calculate Europe/Zurich time based on dates where
+    // daylight saving times change.
     local formatDate(date) =
       local lastChange = std.reverse([t for t in std.objectFields(dst) if t < date])[0];
       local UTCOffset = dst[lastChange];
@@ -101,7 +109,6 @@ spec:
       };
 
     if upgradeWindow != null then makeConsoleNotification('upgrade-%s' % replacementValues['$OVERLAY_VERSION'], config.notification, replacementValues)
-    #[nextChannelOverlay.date, formatDate(nextChannelOverlay.date)]
   triggers:
     - name: clusterversion_appuio
       watchContextResource: