Skip to content

Dropping node-fetch #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slagiewka opened this issue Jan 10, 2025 · 1 comment · May be fixed by #400
Open

Dropping node-fetch #393

slagiewka opened this issue Jan 10, 2025 · 1 comment · May be fixed by #400

Comments

@slagiewka
Copy link

slagiewka commented Jan 10, 2025

What's the way ahead for this lib and node-fetch?

Should datasource-rest@v7 come, what would be the minimal supported node version?

Since node 21, the global fetch (undici-based) is stable. Should the global fetch be used as the default for HTTPCache, the node-fetch dependency could be dropped.

Users could still provide their own fetch impl as they do know, but the library would be less prone to more and more issues related to the outdated node-fetch v2 (e.g. #331). Caring about v3 (ESM only) will also become a non-issue.

Known obstacles:

@slagiewka slagiewka linked a pull request Feb 3, 2025 that will close this issue
@slagiewka
Copy link
Author

Drafted as #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant