fix: remove circular dep in admin svc, adjusts default superuser env flag name and default (#572)

* fix: adjust env var name, default in application.properties vs code and redefine log

* fix: remove circular ref

(cherry picked from commit f302f45)

Author: maranmaran

src/main/java/org/apache/pulsar/manager/PulsarApplicationListener.java

@@ -60,8 +60,8 @@ public class PulsarApplicationListener implements ApplicationListener<ContextRef
     @Value("${default.environment.bookie_url}")
     private String defaultEnvironmentBookieUrl;
 
-    @Value("${default.superuser.enable}")
-    private Boolean defaultSuperuserEnable = false;
+    @Value("${default.superuser.enabled}")
+    private Boolean defaultSuperuserEnabled;
 
     @Value("${default.superuser.name}")
     private String defaultSuperuserName;
@@ -94,8 +94,8 @@ public void onApplicationEvent(ContextRefreshedEvent event) {
     }
 
     private void seedDefaultSuperuser() {
-        if(defaultSuperuserEnable == false) {
-            log.debug("Superuser seed disabled");
+        if(defaultSuperuserEnabled == false) {
+            log.info("Superuser seed via application.properties is disabled");
             return;
         }
 

src/main/java/org/apache/pulsar/manager/service/impl/PulsarAdminServiceImpl.java

@@ -71,9 +71,6 @@ public class PulsarAdminServiceImpl implements PulsarAdminService {
     @Autowired
     private EnvironmentsRepository environmentsRepository;
 
-    @Autowired
-    private EnvironmentCacheService environmentCacheService;
-
     @PreDestroy
     public void destroy() {
         pulsarAdmins.values().forEach(value -> value.close());

src/main/resources/application.properties

@@ -134,7 +134,7 @@ default.environment.service_url=
 default.environment.bookie_url=
 
 # default superuser configuration
-default.superuser.enable=
+default.superuser.enabled=false
 default.superuser.name=
 default.superuser.password=
 default.superuser.email=