Skip to content

Commit 4bf95a4

Browse files
committed
Move InputLocation/InputLocationTracker/InputSource to velocity templates
This PR moves the InputLocation, InputLocationTracker, and InputSource classes from maven-api-model to be generated using the existing velocity templates in src/mdo/java/. Changes Made: - Updated Velocity Templates with Maven-specific features controlled by isMavenModel parameter - Added locationTracking=true and generateLocationClasses=true parameters to maven-api-model configuration - Removed manually written InputLocation classes from api/maven-api-model/src/main/java/org/apache/maven/api/model/ Benefits: - Consistency: InputLocation classes are now generated consistently across all Maven modules - Maintainability: Changes can be made in one place (the templates) rather than maintaining separate implementations - Feature Parity: All Maven-specific features are preserved through the isMavenModel boolean parameter - Code Reuse: The same templates can generate both simple and Maven-enhanced versions
1 parent 06769f5 commit 4bf95a4

File tree

7 files changed

+161
-368
lines changed

7 files changed

+161
-368
lines changed

api/maven-api-model/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ under the License.
5959
<params>
6060
<param>packageModelV4=org.apache.maven.api.model</param>
6161
<param>isMavenModel=true</param>
62+
<param>locationTracking=true</param>
63+
<param>generateLocationClasses=true</param>
6264
</params>
6365
</configuration>
6466
<executions>

api/maven-api-model/src/main/java/org/apache/maven/api/model/InputLocation.java

Lines changed: 0 additions & 208 deletions
This file was deleted.

api/maven-api-model/src/main/java/org/apache/maven/api/model/InputLocationTracker.java

Lines changed: 0 additions & 32 deletions
This file was deleted.

api/maven-api-model/src/main/java/org/apache/maven/api/model/InputSource.java

Lines changed: 0 additions & 125 deletions
This file was deleted.

0 commit comments

Comments
 (0)