e can't be empty

arturobernalg · arturobernalg · commit 5ddeb0420305 · 2025-09-09T11:58:35.000+02:00
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/ScramScheme.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/ScramScheme.java
@@ -293,6 +293,9 @@ public void processChallenge(
         final String err = attrs.get("e");
         if (err != null) {
             this.state = State.FAILED;
+            if (err.isEmpty()) {
+                throw new MalformedChallengeException("SCRAM server error attribute 'e' is empty");
+            }
             throw new AuthenticationException("SCRAM server error: " + err);
         }
         final String vB64 = attrs.get("v");
@@ -675,7 +678,4 @@ public String toString() {
         }
     }
 
-    private static boolean isBlank(final String s) {
-        return s == null || s.isEmpty();
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -293,6 +293,9 @@ public void processChallenge(`
`293`	`293`	`final String err = attrs.get("e");`
`294`	`294`	`if (err != null) {`
`295`	`295`	`this.state = State.FAILED;`
	`296`	`+ if (err.isEmpty()) {`
	`297`	`+ throw new MalformedChallengeException("SCRAM server error attribute 'e' is empty");`
	`298`	`+ }`
`296`	`299`	`throw new AuthenticationException("SCRAM server error: " + err);`
`297`	`300`	`}`
`298`	`301`	`final String vB64 = attrs.get("v");`
`@@ -675,7 +678,4 @@ public String toString() {`
`675`	`678`	`}`
`676`	`679`	`}`
`677`	`680`
`678`		`- private static boolean isBlank(final String s) {`
`679`		`- return s == null \|\| s.isEmpty();`
`680`		`- }`
`681`	`681`	`}`