Difficulty reconciling table option types for listing vs direct usage #16763
ianthetechie
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
When adding a data source to the context, I think the current story around types is a bit clunky, but I wanted to start a discussion to make sure that 1) I'm not missing something, and 2) this isn't just me hitting it a a bad time in the middle of a refactor ;) I tried to search for similar issues but couldn't find anything, so here I am!
What I think is clunky:
When writing some code like
ctx.register_parquet
, I need to pass a typeParquetReadOptions<'_>
. However when I want to create aListingTable
, there is no way to pass these on. The closest I could do is to is create aParquetFormat
and (maybe a method call, likewith_options
later) specify someParquetOptions
which are similar but not the same. It looks like there is aTryFrom
impl forParquetWriterOptions
.There is a similar story for CSV, though a few details differ.
It looks like there is also a family of types like
CsvOptions
that get used in the file format APIs. Are these eventually going to be some common subset between reader and writer options which could be used for setting listing table options and theregister_X
(whereX
is a format) paths alike? Or am I just thinking about this wrong?Beta Was this translation helpful? Give feedback.
All reactions