Merge pull request #158 from shapeblue/fixup-vm-details-update

kiranchavala · web-flow · commit 6fbf6ff25807 · 2025-09-09T12:38:02.000+05:30
Fix update of VM details
diff --git a/cloudstack/resource_cloudstack_instance.go b/cloudstack/resource_cloudstack_instance.go
@@ -768,6 +768,11 @@ func resourceCloudStackInstanceUpdate(d *schema.ResourceData, meta interface{})
 			}
 		}
 		p.SetDetails(vmDetails)
+		_, err := cs.VirtualMachine.UpdateVirtualMachine(p)
+		if err != nil {
+			return fmt.Errorf(
+				"Error updating the details for instance %s: %s", vmDetails, err)
+		}
 	}
 
 	return resourceCloudStackInstanceRead(d, meta)

Original file line number	Diff line number	Diff line change
`@@ -768,6 +768,11 @@ func resourceCloudStackInstanceUpdate(d *schema.ResourceData, meta interface{})`
`768`	`768`	`}`
`769`	`769`	`}`
`770`	`770`	`p.SetDetails(vmDetails)`
	`771`	`+ _, err := cs.VirtualMachine.UpdateVirtualMachine(p)`
	`772`	`+ if err != nil {`
	`773`	`+ return fmt.Errorf(`
	`774`	`+ "Error updating the details for instance %s: %s", vmDetails, err)`
	`775`	`+ }`
`771`	`776`	`}`
`772`	`777`
`773`	`778`	`return resourceCloudStackInstanceRead(d, meta)`