Skip to content

Conversation

@stankiewicz
Copy link
Contributor

Add traceparent and tracestate as part of context propagation
https://www.w3.org/TR/trace-context/


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the model label Dec 2, 2025
@stankiewicz
Copy link
Contributor Author

R: @kennknowles

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates OpenTelemetry's traceparent and tracestate fields into the Beam Fn API's ElementMetadata protobuf definition. This foundational change enables robust distributed tracing and context propagation within the Beam execution model, aligning with the W3C Trace Context specification for improved observability.

Highlights

  • OpenTelemetry Integration: Introduces traceparent and tracestate fields into the ElementMetadata protobuf message, facilitating OpenTelemetry context propagation.
  • Distributed Tracing Support: Enhances the beam_fn_api.proto to support W3C Trace Context, allowing for better observability and distributed tracing across Beam's execution graph.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@stankiewicz
Copy link
Contributor Author

R: @sjvanrossum

@stankiewicz
Copy link
Contributor Author

R: @kennknowles

@kennknowles
Copy link
Member

LGTM but maybe someone broke HEAD...

// extensible and backward compatible
message ElementMetadata {
optional DrainMode.Enum drain = 1;
optional string traceparent = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can some comments be added on what they are and/or link to doc? I'm guessing parent is some id? but what is trace state? Should it be an enum? Should either of these be bytes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback. It've linked to the doc and added the comment and example

@stankiewicz stankiewicz force-pushed the tracing_model branch 2 times, most recently from 44b9951 to 6aab0af Compare December 5, 2025 09:19
@stankiewicz
Copy link
Contributor Author

Run Python PreCommit 3.12

@stankiewicz
Copy link
Contributor Author

Run Python_ML PreCommit 3.13

@stankiewicz
Copy link
Contributor Author

Run Java_PVR_Prism_Loopback PreCommit

@stankiewicz
Copy link
Contributor Author

I will try to make it green like before.

@kennknowles
Copy link
Member

OK this is just too silly. That test needs to be modified or something if it is so unreliable. LGTM and I'll merge.

@kennknowles
Copy link
Member

Actually, nit: can you make the commit description nice. Like "[OpenTelemetry] Add traceparent and tracestate to extended element metadata proto"

@kennknowles kennknowles merged commit a6932b6 into apache:master Dec 5, 2025
108 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants