-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[OpenTelemetry] Add traceparent and tracestate #36963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @kennknowles |
Summary of ChangesHello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates OpenTelemetry's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
R: @sjvanrossum |
|
R: @kennknowles |
|
LGTM but maybe someone broke HEAD... |
| // extensible and backward compatible | ||
| message ElementMetadata { | ||
| optional DrainMode.Enum drain = 1; | ||
| optional string traceparent = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can some comments be added on what they are and/or link to doc? I'm guessing parent is some id? but what is trace state? Should it be an enum? Should either of these be bytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the feedback. It've linked to the doc and added the comment and example
5299d93 to
9f111fd
Compare
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto
Outdated
Show resolved
Hide resolved
44b9951 to
6aab0af
Compare
|
Run Python PreCommit 3.12 |
|
Run Python_ML PreCommit 3.13 |
|
Run Java_PVR_Prism_Loopback PreCommit |
|
I will try to make it green like before. |
|
OK this is just too silly. That test needs to be modified or something if it is so unreliable. LGTM and I'll merge. |
|
Actually, nit: can you make the commit description nice. Like "[OpenTelemetry] Add traceparent and tracestate to extended element metadata proto" |
6aab0af to
3599b6a
Compare
Add traceparent and tracestate as part of context propagation
https://www.w3.org/TR/trace-context/
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.