Skip to content

Commit 7044e19

Browse files
authored
#453 fix typeo introduced in #389 (#454)
I introduced this bug in #389 - my apologies. Fixes #453.
1 parent 8aed969 commit 7044e19

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/ArrowTypes/src/ArrowTypes.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ This will then be available to access by overloading `ArrowTypes.JuliaType(::Val
119119
function arrowmetadata end
120120
const EMPTY_STRING = ""
121121
arrowmetadata(T) = EMPTY_STRING
122-
arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata{T}
123-
arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata{T}
122+
arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata(T)
123+
arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata(T)
124124
arrowmetadata(::Type{Nothing}) = EMPTY_STRING
125125
arrowmetadata(::Type{Missing}) = EMPTY_STRING
126126
arrowmetadata(::Type{Any}) = EMPTY_STRING

src/ArrowTypes/test/tests.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ end
3838
@test !ArrowTypes.hasarrowname(Int)
3939

4040
@test ArrowTypes.arrowmetadata(Int) == ""
41+
@test ArrowTypes.arrowmetadata(Union{Nothing,Int}) == ""
42+
@test ArrowTypes.arrowmetadata(Union{Missing,Int}) == ""
4143

4244
@test ArrowTypes.JuliaType(1) === nothing
4345
@test ArrowTypes.JuliaType(1, Int) === nothing

0 commit comments

Comments
 (0)