feature(Device last seen to equal checkin time): update device last seen (#436)

- modify event checkin mutation
- modify cancel event mutation
- fix tests
[finishes #166539920]

Author: mnswaleh

api/events/schema.py

@@ -11,9 +11,10 @@
 from helpers.calendar.analytics_helper import CommonAnalytics
 from helpers.auth.user_details import get_user_from_db
 from helpers.pagination.paginate import ListPaginate
+from helpers.devices.devices import update_device_last_seen
 import pytz
 from dateutil import parser
-from datetime import datetime
+from datetime import datetime, timedelta
 
 
 class Events(SQLAlchemyObjectType):
@@ -48,6 +49,8 @@ class Arguments:
 
     def mutate(self, info, **kwargs):
         room_id, event = check_event_in_db(self, info, "checked_in", **kwargs)
+        if kwargs.get('check_in_time'):
+            update_device_last_seen(info, room_id, kwargs['check_in_time'])
         if not event:
             event = EventsModel(
                 event_id=kwargs['event_id'],
@@ -78,6 +81,12 @@ class Arguments:
     def mutate(self, info, **kwargs):
         # mutation to create an event
         room_id, event = check_event_in_db(self, info, "cancelled", **kwargs)
+        try:
+            device_last_seen = parser.parse(
+                    kwargs['start_time']) + timedelta(minutes=10)
+        except ValueError:
+            raise GraphQLError("Invalid start time")
+        update_device_last_seen(info, room_id, device_last_seen)
         if not event:
             event = EventsModel(
                 event_id=kwargs['event_id'],

fixtures/analytics/query_all_analytics_fixtures.py

@@ -54,6 +54,23 @@
               "durationInMinutes": 45
             }
           ]
+        },
+        {
+          "roomName": "Tana",
+          "cancellations": 0,
+          "cancellationsPercentage": 0.0,
+          "autoCancellations": 0,
+          "numberOfBookings": 0,
+          "checkins": 0,
+          "checkinsPercentage": 0.0,
+          "bookingsPercentageShare": 0.0,
+          "appBookings": 0,
+          "appBookingsPercentage": 0.0,
+          "events": [
+            {
+              "durationInMinutes": 0
+            }
+          ]
         }
       ],
       "bookingsCount": [

fixtures/events/event_checkin_fixtures.py

@@ -38,6 +38,28 @@
     }
 }
 
+event_2_checkin_mutation = '''mutation {
+    eventCheckin(
+        calendarId:"[email protected]",
+        eventId:"test_id6", eventTitle:"Onboarding 2", numberOfParticipants: 4,
+        startTime:"2019-07-10T09:00:00Z",
+        endTime:"2018-07-10T09:45:00Z",
+        checkInTime:"2018-07-10T09:00:00Z"){
+            event{
+                eventId
+                roomId
+                checkedIn
+                cancelled
+                room{
+                    id
+                    name
+                    calendarId
+                }
+            }
+        }
+    }
+'''
+
 wrong_calendar_id_checkin_mutation = '''mutation {
     eventCheckin(
         calendarId:"fake_calendar_id",
@@ -84,6 +106,29 @@
 
 cancel_event_respone = "Event cancelled but email not sent"
 
+cancel_event_invalid_start_time = '''
+    mutation {
+        cancelEvent(
+        calendarId:"[email protected]",
+        eventId:"test_id5", eventTitle:"Onboarding", numberOfParticipants: 4,
+        startTime:"invalid",
+        endTime:"2018-07-10T09:45:00Z")
+        {
+            event{
+                eventId
+                roomId
+                checkedIn
+                cancelled
+                room{
+                    id
+                    name
+                    calendarId
+                }
+            }
+        }
+    }
+'''
+
 checkin_mutation_for_event_existing_in_db = '''mutation {
     eventCheckin(
         calendarId:"[email protected]",

fixtures/location/all_locations_fixtures.py

@@ -35,6 +35,18 @@
                                 "description": "The description"
                             }
                         ]
+                    },
+                    {
+                        "name": "Tana",
+                        "roomType": "meeting",
+                        "capacity": 14,
+                        "roomTags": [
+                            {
+                                "name": "Block-B",
+                                "color": "green",
+                                "description": "The description"
+                            }
+                        ]
                     }
                 ]
             },
@@ -87,10 +99,18 @@
 
 expected_all_location_no_hierachy = {
     'data': {'allLocations': [
-        {'rooms': [{'name': 'Entebbe',
+        {'rooms': [
+                {
+                    'name': 'Entebbe',
+                    'roomType': 'meeting',
+                    'capacity': 6
+                },
+                {
+                    'name': 'Tana',
                     'roomType': 'meeting',
-                    'capacity': 6}
-                   ]},
+                    'capacity': 14
+                },
+            ]},
         {'rooms': []},
         {'rooms': []}
     ]

fixtures/location/rooms_in_location_fixtures.py

@@ -17,6 +17,12 @@
                 "capacity": 6,
                 "roomType": "meeting",
                 "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
+            },
+            {
+                "name": "Tana",
+                "capacity": 14,
+                "roomType": "meeting",
+                "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
             }
         ]
     }

fixtures/room/create_room_fixtures.py

@@ -237,12 +237,20 @@
 
 db_rooms_query_response = {
     "data": {
-        "rooms": [{
+        "rooms": [
+            {
                 "name": "Entebbe",
                 "capacity": 6,
                 "roomType": "meeting",
                 "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
-            }]
+            },
+            {
+                "name": "Tana",
+                "capacity": 14,
+                "roomType": "meeting",
+                "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
+            }
+        ]
     }
 }
 
@@ -261,6 +269,18 @@
                         }
                     ],
                     "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
+                },
+                {
+                    "name": "Tana",
+                    "capacity": 14,
+                    "roomType": "meeting",
+                    "roomTags": [
+                        {
+                            "name": "Block-B",
+                            "color": "green"
+                        }
+                    ],
+                    "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
                 }
             ]
         }

fixtures/room/filter_room_fixtures.py

@@ -43,6 +43,12 @@
                     "capacity": 6,
                     "roomType": "meeting",
                     "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
+                },
+                {
+                    "name": "Tana",
+                    "capacity": 14,
+                    "roomType": "meeting",
+                    "imageUrl": "https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg"  # noqa: E501
                 }
             ]
         }
@@ -181,7 +187,7 @@
 }
 
 filter_rooms_by_room_labels = '''query {
-  allRooms(roomLabels:"Wing"){
+  allRooms(roomLabels:"Wing A"){
    rooms{
       name
       capacity
@@ -209,7 +215,7 @@
     }
 }
 filter_rooms_by_location_room_labels = '''query {
-  allRooms(roomLabels:"Wing", location:"Kampala"){
+  allRooms(roomLabels:"Wing A", location:"Kampala"){
    rooms{
       name
       capacity

fixtures/room/query_room_fixtures.py

@@ -32,9 +32,9 @@
                     "name": "Entebbe"
                 }
             ],
-            "hasNext": False,
+            "hasNext": True,
             "hasPrevious": False,
-            "pages": 1
+            "pages": 2
         }
     }
 }

helpers/devices/__init__.py

@@ -0,0 +1,14 @@
+from graphql import GraphQLError
+from api.devices.models import Devices as DeviceModel
+from api.devices.schema import Devices as DeviceSchema
+
+
+def update_device_last_seen(info, room_id, check_in_time):
+    device_query = DeviceSchema.get_query(info)
+    device = device_query.filter(
+                DeviceModel.room_id == room_id
+            ).first()
+    if not device:
+        raise GraphQLError("Room device not found")
+    device.last_seen = check_in_time
+    device.save()

helpers/devices/devices.py

@@ -90,6 +90,16 @@ def setUp(self):
                         room_labels=["1st Floor", "Wing A"])
             room.save()
             room.room_tags.append(tag)
+            room_2 = Room(name='Tana',
+                        room_type='meeting',
+                        capacity=14,
+                        location_id=location.id,
+                        structure_id='851ae8b3-48dd-46b5-89bc-ca3f8111ad87',
+                        calendar_id='[email protected]',  # noqa: E501
+                        image_url="https://www.officelovin.com/wp-content/uploads/2016/10/andela-office-main-1.jpg",  # noqa: E501
+                        room_labels=["1st Floor", "Wing B"])
+            room_2.save()
+            room_2.room_tags.append(tag)
             resource = Resource(name='Markers',
                                 quantity=3)
             resource.save()
@@ -98,7 +108,8 @@ def setUp(self):
                 date_added="2018-06-08T11:17:58.785136",
                 name="Samsung",
                 location="Kampala",
-                device_type="External Display"
+                device_type="External Display",
+                room_id=1
             )
             device.save()
             question_1 = Question(

tests/base.py

@@ -4,10 +4,12 @@
 from tests.base import BaseTestCase, CommonTestCases
 from fixtures.events.event_checkin_fixtures import (
     event_checkin_mutation,
+    event_2_checkin_mutation,
     event_checkin_response,
     wrong_calendar_id_checkin_mutation,
     cancel_event_mutation,
     cancel_event_respone,
+    cancel_event_invalid_start_time,
     checkin_mutation_for_event_existing_in_db,
     response_for_event_existing_in_db_checkin
 )
@@ -53,6 +55,17 @@ def test_checkin_with_invalid_calendar_id(self):
             "This Calendar ID is invalid"
         )
 
+    def test_checkin_room_with_no_device(self):
+        """
+        Test that user can not checkin to a room
+        without a device assigned to the room
+        """
+        CommonTestCases.user_token_assert_in(
+            self,
+            event_2_checkin_mutation,
+            "Room device not found"
+        )
+
     @patch("api.events.schema.get_single_calendar_event", spec=True)
     def test_cancel_event(self, mocked_method):
         '''
@@ -65,6 +78,18 @@ def test_cancel_event(self, mocked_method):
             cancel_event_respone
         )
 
+    @patch("api.events.schema.get_single_calendar_event", spec=True)
+    def test_cancel_event_with_invalid_start_time(self, mocked_method):
+        '''
+        Test that user can not cancel event with invalid start time
+        '''
+        mocked_method.return_value = get_events_mock_data()['items'][0]
+        CommonTestCases.user_token_assert_in(
+            self,
+            cancel_event_invalid_start_time,
+            'Invalid start time'
+        )
+
     @patch("api.events.schema.get_single_calendar_event", spec=True)
     def test_cancel_event_twice(self, mocked_method):
         '''