Add MergeMaterial component and deprecate MergeToonLit component #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
force-pushed
the
merge-material
branch
from
9fafa32 to
eacb373
Compare
… ToonLit Material
This comment was marked as off-topic.
This comment was marked as off-topic.
Sayamame-beans
requested changes
Oct 25, 2025
Comment on lines
14
to
15
| このコンポーネントは非推奨です。代わりに[Trace and Optimize](../trace-and-optimize)の`使われていないObjectを自動的に削除する`を使用してください。 | ||
| このコンポーネントの動作が改善されることはありません。 |
There was a problem hiding this comment.
Suggested change
| このコンポーネントは非推奨です。 | |
| 代わりに[Trace and Optimize](../trace-and-optimize)の`使われていないObjectを自動的に削除する`を使用してください。\ | |
| このコンポーネントの動作が改善されることはありません。 |
Comment on lines
14
to
15
| This component is obsolete. You should use `Remove unused Objects` of [Trace and Optimize](../trace-and-optimize) instead. | ||
| This component will never get algorithm improvements. |
There was a problem hiding this comment.
Suggested change
| This component is obsolete. | |
| You should use `Remove unused Objects` of [Trace and Optimize](../trace-and-optimize) instead.\ | |
| This component will never get algorithm improvements. |
Make Childrenの方はdeprecated表記になってたことに気付きました。使い分けの意図がなければどちらかに揃えておいても良いですね。
There was a problem hiding this comment.
一応後継があるかって違いはあるけど揃えてもいかもしれない
Sayamame-beans
requested changes
Oct 28, 2025
| msgstr "代表マテリアル" | ||
|
|
||
| msgid "MergeMaterial:Reference Material:tooltip" | ||
| msgstr "統合先のマテリアルとして使用されるマテリアルです。このマテリアルのシェーダーの設定が統合後のマテリアルに使用されます。" |
There was a problem hiding this comment.
Suggested change
| msgstr "統合先のマテリアルとして使用されるマテリアルです。このマテリアルのシェーダーの設定が統合後のマテリアルに使用されます。" | |
| msgstr "統合後のマテリアルのシェーダー設定に利用されます。" |
There was a problem hiding this comment.
シェーダーの設定って書き方が良くないか。テクスチャ以外のプロパティ全部これからコピペされます
|
|
||
| msgid "MergeToonLitMaterial:suggestMigrate" | ||
| msgstr "" | ||
| "MergeToonLitMaterial is obsoleted by MergeMaterial wich supports more shaders!\n" |
There was a problem hiding this comment.
Suggested change
| "MergeToonLitMaterial is obsoleted by MergeMaterial wich supports more shaders!\n" | |
| "MergeToonLitMaterial is obsoleted by MergeMaterial which supports more shaders and has better save format!\n" |
| msgstr "Multiple merge settings uses same material as a source material. This is not supported behavior." | ||
|
|
||
| msgid "MergeMaterial:error:MaterialNotFoundInMesh" | ||
| msgstr "The material configured in the MergeMaterial is not exists in the Skinned Mesh Renderer." |
There was a problem hiding this comment.
configuredって統合前後でいうとどっちでしょうか
There was a problem hiding this comment.
統合後のマテリアルって設定ないかな。統合前のほとんど参照とテクスチャ参照用のマテリアルなので
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new version of MaterialToonLit: Merge Material.
This new component:
Closes #68 improve UI of Merge ToonLit
Closes #273 Merge MaterialをlilToonに対応させて欲しい
Closes #363 merge toonlit/materialのマテリアル指定がMergeSkinnedMeshの変更にすごく弱い
Closes #1455 More ShaderSupport for MergeToonLit / Merge Material
Closes #1519 Request for lilToonMultiOutline
TODOs:
Reimplement MergeToonLit with new MergeMaterial implementationwe don't