Feat: Remove skip of BlankLineAfterOpeningTagFixer

Author: Martin Guth

CHANGELOG.md

@@ -5,6 +5,7 @@
 <!-- There is always Unreleased section on the top. Subsections (Added, Changed, Fixed, Removed) should be added as needed. -->
 
 ## Unreleased
+- Remove skip of BlankLineAfterOpeningTagFixer to be PSR-12 compliant.
 
 ## 4.2.0 - 2025-02-28
 - Rename the package from "Alma Career Czechia Standard for PHP" to more broad "Alma Career Coding Standard for PHP". 🎉

README.md

@@ -46,7 +46,9 @@ composer require --dev almacareer/coding-standard
 1. Create `ecs.php` file in the root directory of your project and import the code-style rules:
 
 ```php
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 use Lmc\CodingStandard\Set\SetList;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
@@ -92,7 +94,9 @@ If needed, you can also override any default settings.
 Below find examples of some more opinionated checks you may want to add depending on your needs:
 
 ```php
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 use Lmc\CodingStandard\Set\SetList;
 use PHP_CodeSniffer\Standards\Generic\Sniffs\Files\LineLengthSniff;
@@ -133,7 +137,9 @@ See [EasyCodingStandard docs][ecs-docs] for more configuration options.
 You can configure your `ecs.php` file to entirely skip some files, disable specific checks, or suppress specific errors.
 
 ```php
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 use PHP_CodeSniffer\Standards\Generic\Sniffs\PHP\ForbiddenFunctionsSniff;
 use PHP_CodeSniffer\Standards\Squiz\Sniffs\Arrays\ArrayDeclarationSniff;

composer.json

@@ -29,7 +29,10 @@
     "autoload": {
         "psr-4": {
             "Lmc\\CodingStandard\\": "src/"
-        }
+        },
+        "files": [
+            "src/polyfill.php"
+        ]
     },
     "autoload-dev": {
         "psr-4": {

ecs-internal.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 use Lmc\CodingStandard\Set\SetList;
 use PHP_CodeSniffer\Standards\Generic\Sniffs\PHP\ForbiddenFunctionsSniff;

ecs.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 use Lmc\CodingStandard\Fixer\SpecifyArgSeparatorFixer;
 use Lmc\CodingStandard\Sniffs\Naming\AbstractClassNameSniff;
@@ -127,7 +129,6 @@
 use PhpCsFixer\Fixer\Phpdoc\PhpdocTrimFixer;
 use PhpCsFixer\Fixer\Phpdoc\PhpdocTypesFixer;
 use PhpCsFixer\Fixer\Phpdoc\PhpdocVarAnnotationCorrectOrderFixer;
-use PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer;
 use PhpCsFixer\Fixer\PhpTag\FullOpeningTagFixer;
 use PhpCsFixer\Fixer\PhpUnit\PhpUnitConstructFixer;
 use PhpCsFixer\Fixer\PhpUnit\PhpUnitDedicateAssertFixer;
@@ -638,7 +639,4 @@
         // Skip unwanted rules from ReturnTypeHintSniff
         ReturnTypeHintSniff::class . '.' . ReturnTypeHintSniff::CODE_MISSING_TRAVERSABLE_TYPE_HINT_SPECIFICATION => null,
         ReturnTypeHintSniff::class . '.' . ReturnTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT => null,
-
-        // We use declare(strict_types=1); after opening tag
-        BlankLineAfterOpeningTagFixer::class => null,
     ]);

phpstan.neon

@@ -6,10 +6,3 @@ parameters:
     bootstrapFiles:
         - vendor/symplify/easy-coding-standard/vendor/squizlabs/php_codesniffer/autoload.php
         - vendor/symplify/easy-coding-standard/vendor/squizlabs/php_codesniffer/src/Util/Tokens.php
-    ignoreErrors:
-        - path: %currentWorkingDirectory%/tests/Fixer/SpecifyArgSeparatorFixerTest.php
-          message: '#Parameter \#1 \$code of static method PhpCsFixer\\Tokenizer\\Tokens::fromCode\(\) expects string, string\|false given#'
-        - path: %currentWorkingDirectory%/tests/Integration/CodingStandardTest.php
-          message: '#Parameter \#2 \$actualString of method PHPUnit\\Framework\\Assert::assertStringEqualsFile\(\) expects string, string\|false given#'
-        - identifier: missingType.iterableValue
-          path: %currentWorkingDirectory%/tests/*

src/Fixer/SpecifyArgSeparatorFixer.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace Lmc\CodingStandard\Fixer;
 

src/Helper/Naming.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 /*
  * Originally part of https://github.com/symplify/symplify
@@ -79,7 +81,7 @@ public function getClassName(File $file, int $classNameStartPosition): string
 
         $fqnClassName = $this->getFqnClassName($file, $completeClassName, $classNameStartPosition);
         if ($fqnClassName !== '') {
-            return ltrim($fqnClassName, self::NAMESPACE_SEPARATOR);
+            return mb_ltrim($fqnClassName, self::NAMESPACE_SEPARATOR);
         }
 
         return $completeClassName;

src/Helper/SniffClassWrapper.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 /*
  * Originally part of https://github.com/symplify/symplify

src/Set/SetList.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace Lmc\CodingStandard\Set;