Move Filter under Model directory #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mausham-shrestha-aligent
requested review from
aligent-lturner and
quangdo-aligent
quangdo-aligent
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a typo in the namespace that caused the indexer_reindex_all_invalid to fail. I had initially assumed that no products had been updated during this period. The issue was further obscured by the presence of old queues, which I mistakenly assumed were new ones during verification in both Prod and Stage environments.
Investigation Notes
No issues were encountered during setup:di:compile or while running the indexer:reindex prerender_* commands in the local environment. Everything appeared to work as expected when I created PR earlier.
However, it’s likely that indexer_reindex_all_invalid performs a more thorough validation compared to the individual indexers. This may have caused the typo to go unnoticed locally.
To add to the confusion, Ctrl+Click correctly navigated to the (incorrectly named) function, which gave the impression that everything was wired up correctly.
Pipeline didn't highlighted the issue too.
Resolution
Moved Filter to Model directory