Skip to content

Commit 98d01a1

Browse files
committed
minor fix
Committed-by: bingqing.lbq from Dev container
1 parent 1c2744a commit 98d01a1

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

interactive_engine/executor/common/dyn_type/src/object.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -540,9 +540,6 @@ impl PartialOrd for Primitives {
540540
.as_f64()
541541
.map(|o| v.partial_cmp(&o))
542542
.unwrap_or(None),
543-
Primitives::UInteger(_) => todo!(),
544-
Primitives::ULong(_) => todo!(),
545-
Primitives::Float(_) => todo!(),
546543
}
547544
}
548545
}

interactive_engine/executor/ir/graph_proxy/src/adapters/gs_store/read_graph.rs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ fn encode_store_prop_val(prop_val: Object) -> Property {
682682
Primitives::UInteger(i) => Property::UInt(i),
683683
Primitives::Long(i) => Property::Long(i),
684684
Primitives::ULong(i) => Property::ULong(i),
685-
Primitives::ULLong(i) => Property::ULong(i as u64),
685+
Primitives::ULLong(i) => Property::ULong(i),
686686
Primitives::Float(f) => Property::Float(f),
687687
Primitives::Double(f) => Property::Double(f),
688688
},
@@ -691,14 +691,6 @@ fn encode_store_prop_val(prop_val: Object) -> Property {
691691
if let Some(probe) = vec.get(0) {
692692
match probe {
693693
Object::Primitive(p) => match p {
694-
Primitives::Byte(_) | Primitives::Integer(_) | Primitives::UInteger(_) => {
695-
Property::ListInt(
696-
vec.into_iter()
697-
.map(|i| i.as_i32().unwrap())
698-
.collect(),
699-
)
700-
}
701-
Primitives::Long(_) | Primitives::ULong(_) => Property::ListLong(
702694
Primitives::Byte(_) | Primitives::Integer(_) | Primitives::UInteger(_) => {
703695
Property::ListInt(
704696
vec.into_iter()
@@ -721,12 +713,6 @@ fn encode_store_prop_val(prop_val: Object) -> Property {
721713
.map(|i| i.as_f32().unwrap())
722714
.collect(),
723715
),
724-
Primitives::Double(_) => Property::ListDouble(
725-
Primitives::Float(_) => Property::ListFloat(
726-
vec.into_iter()
727-
.map(|i| i.as_f32().unwrap())
728-
.collect(),
729-
),
730716
Primitives::Double(_) => Property::ListDouble(
731717
vec.into_iter()
732718
.map(|i| i.as_f64().unwrap())

0 commit comments

Comments
 (0)