From bbd6eb58085df4b5a9dc727657c4f816379bc505 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sondre=20M=C3=A6re=20Overskaug?= Date: Tue, 11 Oct 2016 13:55:05 +0200 Subject: [PATCH 1/2] fix(iOS): do not remove keyboard event listeners unless they exist --- index.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index f39859f..c41f3b0 100644 --- a/index.js +++ b/index.js @@ -36,8 +36,12 @@ class Tabs extends Component { } componentWillUnmount(){ - this.keyboardDidShowListener.remove(); - this.keyboardDidHideListener.remove(); + if (this.keyboardDidShowListener) { + this.keyboardDidShowListener.remove(); + } + if (this.keyboardDidHideListener) { + this.keyboardDidHideListener.remove(); + } } keyboardWillShow = (e) => { From c709af985dc51ef0732b1b2aee362c4231ecdeb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sondre=20M=C3=A6re=20Overskaug?= Date: Sun, 6 Nov 2016 15:56:10 +0100 Subject: [PATCH 2/2] feat: add support for accessibilityLabel --- index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/index.js b/index.js index c41f3b0..8dfdbfd 100644 --- a/index.js +++ b/index.js @@ -67,6 +67,7 @@ class Tabs extends Component { {React.Children.map(this.props.children.filter(c=>c),(el)=> !self.props.locked && self.onSelect(el)} onLongPress={()=>self.onSelect(el)}